From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Ashok Babu <ashok3d@gmail.com>,
linux-omap@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>
Subject: Re: Adio on BeagleBoard XM 2.6.37-rc8
Date: Wed, 19 Jan 2011 10:51:14 -0800 [thread overview]
Message-ID: <20110119185114.GA4957@atomide.com> (raw)
In-Reply-To: <20110119150233.b27475bc.jhnikula@gmail.com>
* Jarkko Nikula <jhnikula@gmail.com> [110119 05:01]:
> On Wed, 19 Jan 2011 17:17:11 +0530
> Ashok Babu <ashok3d@gmail.com> wrote:
>
> > Hi folks,
> >
> > After upgrading to 2.6.37-rc8, I am not able to play any audio.
> >
> > Fund that the code in sound/soc/omap/omap-mcbsp.c uses the function
> > "cpu_is_omap343x()" which fails and returns ENODEV.
> >
> > Does the call should be "cpu_is_omap34xx()" instead ?
> >
> It looks like so. cpu_is_omap34xx() checks the lowest 8 bits from
> omap_rev (that are 0x34 for omap3x ) and cpu_is_omap343x() checks upper
> 12 bits (that are 0x363 for 3630).
>
> Peter: I think cpu_is_omap343x() tests can be replaced by
> cpu_is_omap34xx() in omap-mcbsp.c?
For next merge window, can you please git rid of cpu_is_omap
and machine_is usage under drivers?
You can pass the necessary flags in platform data.
Regards,
Tony
prev parent reply other threads:[~2011-01-19 18:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 11:47 Adio on BeagleBoard XM 2.6.37-rc8 Ashok Babu
2011-01-19 13:02 ` Jarkko Nikula
2011-01-19 18:51 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119185114.GA4957@atomide.com \
--to=tony@atomide.com \
--cc=ashok3d@gmail.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.