Re: [Qemu-devel] [PULL] piix, pci, qdev

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Jan 19, 2011 at 04:14:48PM +0100, Christoph Hellwig wrote:
> > >       pci: fix migration path for devices behind bridges
> 
> This patch breaks starting qemu for me on 32-bit x86 with the following assert:

Yes, sorry about that.
I sent a fix, could you check out it please?

> qemu-system-x86_64: savevm.c:1129: register_savevm_live: Assertion
> `!se->compat || se->instance_id == 0' failed.
> 
> my qemu command line is:
> 
> /opt/qemu/bin/qemu-system-x86_64 \
> 	-m 1500 \
> 	-enable-kvm \
> 	-drive if=none,file=/dev/vg01/qemu-root,cache=none,aio=threads,id=root \
> 	-drive if=none,file=/dev/vg01/qemu-data,cache=none,aio=threads,id=test \
> 	-drive if=none,file=/home/test1.img,cache=none,id=scratch \
> 	-device virtio-blk-pci,drive=root \
> 	-device virtio-blk-pci,drive=test \
> 	-device virtio-blk-pci,drive=scratch \
> 	-append "root=/dev/vda console=tty0 console=ttyS0,38400n8" \
> 	-monitor tcp:127.0.0.1:31337,server,nowait \
> 	-kernel arch/x86/boot/bzImage \
> 	-nographic
> 
> btw, I can't find a patch for that commit anywhere in the qemu-devel
> archives.  Did it get reviewed anywhere at all?