From: holger@eitzenberger.org
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: netfilter-devel@vger.kernel.org
Subject: [patch 0/2] Ipset patches
Date: Wed, 19 Jan 2011 21:26:07 +0100 [thread overview]
Message-ID: <20110119202607.532407993@eitzenberger.org> (raw)
Hi Jozsef,
what follows are two small patches which remove unneeded argv[]
loops when parsing the ipset commands. They are in particular no
change in command line handling.
The command line handling can still be improved, as e. g.
$ ipset -o xml create foo hash:ip
$ ipset -s add foo 192.168.1.1
both work, but the options are just ignored. And they don't
make much sense for either 'create' or 'add'.
Also we should consider to make the argument handling a little
more strict, as e. g.
$ ipset -o xml list foo
$ ipset list -o xml foo
$ ipset list foo -o xml
all work. By removing some of those possibilities it should even
get simpler code wise.
/holger
--
next reply other threads:[~2011-01-19 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 20:26 holger [this message]
2011-01-19 20:26 ` [patch 1/2] ipset: remove the unneeded argvloop holger
2011-01-19 20:26 ` [patch 2/2] ipset: remove " holger
2011-01-19 21:59 ` [patch 0/2] Ipset patches Jozsef Kadlecsik
-- strict thread matches above, loose matches on Subject: below --
2013-02-21 16:45 [PATCH 0/2] ipset patches Jozsef Kadlecsik
2013-02-25 15:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119202607.532407993@eitzenberger.org \
--to=holger@eitzenberger.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.