All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang Ruirui <ruirui.r.yang@tieto.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Yang Ruirui R <ruirui.r.yang@tietoenator.com>,
	Greg Kroah-Hartman <gregkh@suse.de>, Hao Wu <hao.wu@intel.com>,
	Alan Cox <alan@linux.intel.com>, Alek Du <alek.du@intel.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb langwell otg: use notifier chain of struct otg_transceiver
Date: Thu, 20 Jan 2011 15:03:01 +0800	[thread overview]
Message-ID: <20110120070301.GA24923@darkstar> (raw)
In-Reply-To: <20110120064829.GG2389@legolas.emea.dhcp.ti.com>

On Thu, Jan 20, 2011 at 08:48:29AM +0200, Felipe Balbi wrote:
> Hi,
> 
> On Thu, Jan 20, 2011 at 02:50:40PM +0800, Yang Ruirui wrote:
> > Use notifier chain in otg_transceiver instead of own notifier chain.
> > 
> > This patch depends on another patch which change otg_transceiver
> > notifier chain to atomic, please see:
> > https://lkml.org/lkml/2011/1/19/72
> 
> (just one point, try to break commit logs at 72 characters next time,
> not sure if Greg will ask you to resend, if he does, you can add the
> Reviewed-by line below)

Thank you for pointing out this. I will resend before he ask:)

> 
> > Signed-off-by: Yang Ruirui <ruirui.r.yang@tieto.com>
> 
> I have checked that nobody actually uses
> intel_mid_otg_register_notifier() thus:
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> 
> -- 
> balbi

      reply	other threads:[~2011-01-20  6:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20  6:50 [PATCH] usb langwell otg: use notifier chain of struct otg_transceiver Yang Ruirui
2011-01-20  6:48 ` Felipe Balbi
2011-01-20  7:03   ` Yang Ruirui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110120070301.GA24923@darkstar \
    --to=ruirui.r.yang@tieto.com \
    --cc=alan@linux.intel.com \
    --cc=alek.du@intel.com \
    --cc=balbi@ti.com \
    --cc=gregkh@suse.de \
    --cc=hao.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ruirui.r.yang@tietoenator.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.