Re: [Qemu-devel] [PATCH 0/7] Define "deposit" tcg operation, v2

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Mon, Jan 10, 2011 at 07:23:41PM -0800, Richard Henderson wrote:
> Changes since v1:
>   * No attempt to pack pos+len into one operand.  Updated backends
>     to match this change.
> 
>   * Example in the README is a bit more complex.
> 
>   * Define an official tcg_scratch_alloc routine, used by the i386
>     target for the case in which we need a scratch register.  I had
>     said that triggering this wasn't possible with mainline, but I
>     was wrong.  The rlwimi example I posted in the other thread hits
>     this case.
> 
> Aurelien suggested using a shorter name like "dep", but I think that
> would be more confusing than not.  This opcode is not really used
> enough to warrent cropping 4 characters, in my opinion.

Thanks Richard. In agreement with Aurelien I've applied patch 1 and 6
as a first step. I've also applied a follow-up patch to fix the
copy-pastos in the README (loc -> len).

Hopefully as more acks come in, we'll apply the rest.

Cheers