From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Travis <travis@sgi.com>
Cc: Ingo Molnar <mingo@elte.hu>, Len Brown <len.brown@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jack Steiner <steiner@sgi.com>, Robin Holt <holt@sgi.com>,
Lori Gilbertson <loriann@sgi.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/6] printk: Allocate kernel log buffer earlier
Date: Thu, 20 Jan 2011 15:50:21 -0800 [thread overview]
Message-ID: <20110120155021.c39387c3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110119230106.527741713@gulag1.americas.sgi.com>
On Wed, 19 Jan 2011 17:01:07 -0600
Mike Travis <travis@sgi.com> wrote:
> On larger systems, because of the numerous ACPI, Bootmem and EFI
> messages, the static log buffer overflows before the larger one
> specified by the log_buf_len param is allocated. Minimize the
> overflow by allocating the new log buffer as soon as possible.
>
> All arch's are covered by the "setup_log_buf" in start_kernel().
> The x86 arch allocates it right after bootmem is created.
>
> ...
>
> +void setup_log_buf(void);
>
> ...
>
> +void __init setup_log_buf(void)
>
It's a PITA but the declaration should have the __init tag as well. We
have had at least one instance where failing to do this caused an arch
(arm) to emit a short-mode address offset to a function which it
thought was in the same section as the callsite. Only the target was
in a different section from the callsite and the linker couldn't fit
the needed offset into the operand.
next prev parent reply other threads:[~2011-01-20 23:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 23:01 [PATCH 0/6] init: Shrink early messages to prevent overflowing the kernel log buffer Mike Travis
2011-01-19 23:01 ` [PATCH 1/6] printk: Allocate kernel log buffer earlier Mike Travis
2011-01-20 23:50 ` Andrew Morton [this message]
2011-01-20 23:55 ` Mike Travis
2011-01-21 0:07 ` Andrew Morton
2011-01-19 23:01 ` [PATCH 2/6] ACPI: Minimize X2APIC initial messages Mike Travis
2011-01-19 23:01 ` [PATCH 3/6] x86: Minimize initial Bootmem messages Mike Travis
2011-01-19 23:01 ` [PATCH 4/6] x86: Minimize initial e820 messages Mike Travis
2011-01-19 23:01 ` [PATCH 5/6] x86: Minimize SRAT messages Mike Travis
2011-01-19 23:01 ` [PATCH 6/6] printk: Minimize time zero output Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120155021.c39387c3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=holt@sgi.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loriann@sgi.com \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.