All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Grover <andy.grover@oracle.com>
Cc: linux-mm@kvack.org, rds-devel@oss.oracle.com
Subject: Re: [RESEND PATCH] mm: Use spin_lock_irqsave in __set_page_dirty_nobuffers
Date: Fri, 21 Jan 2011 00:18:04 -0800	[thread overview]
Message-ID: <20110121001804.413b3f6d.akpm@linux-foundation.org> (raw)
In-Reply-To: <1294726534-16438-1-git-send-email-andy.grover@oracle.com>

On Mon, 10 Jan 2011 22:15:34 -0800 Andy Grover <andy.grover@oracle.com> wrote:

> RDS is calling set_page_dirty from interrupt context,

yikes.  Whatever possessed you to try that?

> @@ -1155,11 +1155,12 @@ int __set_page_dirty_nobuffers(struct page *page)

__set_page_dirty_buffers(): bug, takes mapping->private_lock in irq context
                            bug, __set_page_dirty() reenables IRQs
ceph_set_page_dirty():      more bugs than I care to enumerate
nilfs_set_file_dirty():	    bug, takes sbi->s_inode_lock in IRQ context

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-01-21  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11  6:15 [RESEND PATCH] mm: Use spin_lock_irqsave in __set_page_dirty_nobuffers Andy Grover
2011-01-21  8:18 ` Andrew Morton [this message]
2011-01-21 19:25   ` Andy Grover
2011-01-21 20:09     ` Andrew Morton
2011-01-25  1:30       ` Andy Grover
2011-01-25  1:44         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110121001804.413b3f6d.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andy.grover@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.