From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [Intel-gfx] [PATCH 2/5] i915: Add native backlight control Date: Fri, 21 Jan 2011 00:43:59 +0000 Message-ID: <20110121004359.GA6422@srcf.ucam.org> References: <1295033065-13450-1-git-send-email-mjg@redhat.com> <1295033065-13450-2-git-send-email-mjg@redhat.com> <20112101000015@lilem.mirepesht> <20112101004346@lilem.mirepesht> <20110120151349.49cf3ebb.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:39395 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457Ab1AUAoL (ORCPT ); Thu, 20 Jan 2011 19:44:11 -0500 Content-Disposition: inline In-Reply-To: <20110120151349.49cf3ebb.akpm@linux-foundation.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andrew Morton Cc: Ali Gholami Rudi , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org, rpurdie@rpsys.net On Thu, Jan 20, 2011 at 03:13:49PM -0800, Andrew Morton wrote: > On Fri, 21 Jan 2011 00:43:46 +0330 > Ali Gholami Rudi wrote: > > > Ali Gholami Rudi wrote: > > > I tried to apply this patch but I get: > > > > > > drivers/gpu/drm/i915/intel_panel.c: In function 'intel_panel_setup_backlight': > > > drivers/gpu/drm/i915/intel_panel.c:319: error: 'struct backlight_properties' has no member named 'type' > > > drivers/gpu/drm/i915/intel_panel.c:319: error: 'BACKLIGHT_RAW' undeclared (first use in this function) > > > drivers/gpu/drm/i915/intel_panel.c:319: error: (Each undeclared identifier is reported only once > > > drivers/gpu/drm/i915/intel_panel.c:319: error: for each function it appears in.) > > > > After applying patch 1/5, the patch applied cleanly. > > Now I can change the brightness using > > /sys/class/backlight/intel_backlight/brightness. > > So it does fix my issue. > > > > So we have a patch ordering issue and the > radeon-expose-backlight-class-device-for-legacy-lvds-encoder.patch > build error. He applied 2/5, it didn't build, he applied 1/5 and it built? I don't think that's a patch ordering issue :) I think Michel's patch should fix the Radeon one. If not, can you drop that and keep the rest of the set? I'm travelling at the moment and won't have proper build access until the weekend. -- Matthew Garrett | mjg59@srcf.ucam.org