From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Nikolai Kondrashov <spbnick@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input <linux-input@vger.kernel.org>,
Vladislav Naumov <vnaum@vnaum.com>
Subject: Re: [PATCH 1/3] Input: split hid-drff into general and ff parts
Date: Fri, 21 Jan 2011 01:52:43 -0800 [thread overview]
Message-ID: <20110121095243.GD21842@core.coreip.homeip.net> (raw)
In-Reply-To: <1295602215-6056-2-git-send-email-spbnick@gmail.com>
On Fri, Jan 21, 2011 at 12:30:13PM +0300, Nikolai Kondrashov wrote:
> Split DragonRise Inc. HID gamepad driver (hid-drff.c) into a general
> (hid-dr.[hc]) and a force feedback part (hid-drff.c).
>
> Signed-off-by: Nikolai Kondrashov <spbnick@gmail.com>
> ---
> drivers/hid/Makefile | 7 ++++-
> drivers/hid/hid-dr.c | 71 ++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/hid/hid-dr.h | 13 +++++++++
> drivers/hid/hid-drff.c | 63 +-----------------------------------------
> 4 files changed, 92 insertions(+), 62 deletions(-)
> create mode 100644 drivers/hid/hid-dr.c
> create mode 100644 drivers/hid/hid-dr.h
>
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 6efc2a0..ea58795 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -25,6 +25,11 @@ ifdef CONFIG_LOGIWII_FF
> hid-logitech-y += hid-lg4ff.o
> endif
>
> +hid-dragonrise-objs := hid-dr.o
> +ifdef CONFIG_DRAGONRISE_FF
> + hid-dragonrise-objs += hid-drff.o
> +endif
If you want to keep the 2 source files then I think you should write this as:
hid-dragonrise-y := hid-dr.o
hid-dragonrise-$(CONFIG_DRAGONRISE_FF) += hid-drff.o
Or maybe fold them into one?
--
Dmitry
next prev parent reply other threads:[~2011-01-21 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 9:30 [PATCH v2] Input: add support for DragonRise PID 0011 gamepad Nikolai Kondrashov
2011-01-21 9:30 ` [PATCH 1/3] Input: split hid-drff into general and ff parts Nikolai Kondrashov
2011-01-21 9:52 ` Dmitry Torokhov [this message]
2011-01-24 15:28 ` Jiri Kosina
2011-01-24 15:45 ` Nikolai Kondrashov
2011-01-21 9:30 ` [PATCH 2/3] Input: add support for DragonRise PID 0011 gamepad Nikolai Kondrashov
2011-01-21 9:30 ` [PATCH 3/3] Input: update dragonrise Kconfig description Nikolai Kondrashov
-- strict thread matches above, loose matches on Subject: below --
2011-01-13 18:56 [PATCH 0/3] Input: add support for DragonRise PID 0011 gamepad Nikolai Kondrashov
2011-01-13 18:56 ` [PATCH 1/3] Input: split hid-drff into general and ff parts Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121095243.GD21842@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=spbnick@gmail.com \
--cc=vnaum@vnaum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.