From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Naveen Kumar G <naveen.gaddipati@stericsson.com>,
linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com
Subject: Re: [PATCH 2/2] staging: synaptics: Implement error hamdling for rmi4 touch regulator
Date: Fri, 21 Jan 2011 16:14:24 -0800 [thread overview]
Message-ID: <20110122001423.GD27943@core.coreip.homeip.net> (raw)
In-Reply-To: <20110121235431.GA23124@kroah.com>
On Fri, Jan 21, 2011 at 03:54:31PM -0800, Greg KH wrote:
> On Fri, Jan 21, 2011 at 03:33:30PM -0800, Dmitry Torokhov wrote:
> > On Fri, Jan 21, 2011 at 12:38:15PM -0800, Greg KH wrote:
> > > On Fri, Jan 21, 2011 at 03:50:36PM +0530, Naveen Kumar G wrote:
> > > > From: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>
> > > >
> > > > Implement the error handling for regulator in synaptics
> > > > rmi4 touch screen
> > > >
> > > > Signed-off-by: Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>
> > >
> > > This patch has some fuzz and doesn't apply correctly. Care to rediff it
> > > and resend it?
> > >
> >
> > Given that this driver is a [hopefully] dead-end placeholder should we
> > even spend time cleaning this up? It would be better if effor was spent
> > helping Synaptics folks clean up their generic driver...
>
> I agree, but this looks like a new feature being added. We also can't
> keep people from sending patches in, and if Synaptics never comes
> through with their new driver, hey, all the better :)
>
They just posted an update (rework to use our driver model) a few days
ago. If they weren't working on their driver I'd agree wholeheartedly
with improving this driver.
--
Dmitry
prev parent reply other threads:[~2011-01-22 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 10:20 [PATCH 2/2] staging:synaptics: Implement error hamdling for rmi4 touch regulator Naveen Kumar G
2011-01-21 20:38 ` [PATCH 2/2] staging: synaptics: " Greg KH
2011-01-21 23:33 ` Dmitry Torokhov
2011-01-21 23:54 ` Greg KH
2011-01-22 0:14 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110122001423.GD27943@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.gaddipati@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.