All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] libpcap: update static handling
Date: Mon, 24 Jan 2011 17:11:32 +0100	[thread overview]
Message-ID: <20110124171132.6baad50c@surf> (raw)
In-Reply-To: <1295493032-4705-1-git-send-email-vapier@gentoo.org>

Hello,

Completely unrelated to Mike's change, but still spotted while looking
at the patch context:

On Wed, 19 Jan 2011 22:10:29 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

>  LIBPCAP_CONF_ENV:=ac_cv_linux_vers=$(firstword $(subst .,$(space),$(firstword $(call qstrip,$(BR2_DEFAULT_KERNEL_HEADERS))))) \

Both libpcap and tcpdump use this and I never noticed, but this is
completely broken with external toolchains and the Crosstool-NG backend,
since BR2_DEFAULT_KERNEL_HEADERS is only set with internal toolchains.

I haven't thought of what the right fix would be, but it's definitely
not that one.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2011-01-24 16:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20  3:10 [Buildroot] Pull request buildroot.git (vapier branch) Mike Frysinger
2011-01-20  3:10 ` [Buildroot] [PATCH 1/4] libpcap: update static handling Mike Frysinger
2011-01-20  3:10   ` [Buildroot] [PATCH 2/4] debugging: do not require no stripping Mike Frysinger
2011-01-20  3:10   ` [Buildroot] [PATCH 3/4] initial support for Blackfin processors Mike Frysinger
2011-01-20  3:10   ` [Buildroot] [PATCH 4/4] gdb: add support for Blackfin gdbserver Mike Frysinger
2011-01-23 10:17   ` [Buildroot] [PATCH 1/4] libpcap: update static handling Peter Korsgaard
2011-01-23 21:07     ` Mike Frysinger
2011-01-24 16:16       ` Thomas Petazzoni
2011-01-24 16:27         ` Peter Korsgaard
2011-01-24 21:48         ` Mike Frysinger
2011-01-24 21:59           ` Peter Korsgaard
2011-01-25  8:36           ` Thomas Petazzoni
2011-01-24 16:11   ` Thomas Petazzoni [this message]
2011-01-24 16:25     ` Peter Korsgaard
2011-01-24 21:46       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110124171132.6baad50c@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.