All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2: use early init hook
Date: Mon, 24 Jan 2011 18:21:20 -0800	[thread overview]
Message-ID: <20110125022119.GG13589@atomide.com> (raw)
In-Reply-To: <20110124215213.GA27044@n2100.arm.linux.org.uk>

* Russell King - ARM Linux <linux@arm.linux.org.uk> [110124 13:51]:
> On Mon, Jan 24, 2011 at 12:26:29PM -0800, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [110124 12:16]:
> > > 
> > > So far tested on zoom3 only, but the following gets it booting
> > > on top of your patch.
> > 
> > Looks like there are some other patches needed too.. At least
> > omap4 still fails with these.
> 
> From what I remember, the problem I saw on OMAP4 was hwmod related as
> it seemed to be using ioremap() - which with its initialization moved
> before memory allocators were up and running causes an oops.

To me it seems _find_mpu_rt_base should be moved to omap_hwmod_late_init
as we don't want to have a static mapping for everything. AFAIK the
oh->_mpu_rt_va should not be needed early.

Any comments on that Paul? See also the two patches I'll post as a reply
to this thread make omap_hwmod_late_init a core_initcall.

The issue for omap4 still needs to be sorted out. And then we can 
see which omap initcalls really need to be core_initcalls.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2: use early init hook
Date: Mon, 24 Jan 2011 18:21:20 -0800	[thread overview]
Message-ID: <20110125022119.GG13589@atomide.com> (raw)
In-Reply-To: <20110124215213.GA27044@n2100.arm.linux.org.uk>

* Russell King - ARM Linux <linux@arm.linux.org.uk> [110124 13:51]:
> On Mon, Jan 24, 2011 at 12:26:29PM -0800, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [110124 12:16]:
> > > 
> > > So far tested on zoom3 only, but the following gets it booting
> > > on top of your patch.
> > 
> > Looks like there are some other patches needed too.. At least
> > omap4 still fails with these.
> 
> From what I remember, the problem I saw on OMAP4 was hwmod related as
> it seemed to be using ioremap() - which with its initialization moved
> before memory allocators were up and running causes an oops.

To me it seems _find_mpu_rt_base should be moved to omap_hwmod_late_init
as we don't want to have a static mapping for everything. AFAIK the
oh->_mpu_rt_va should not be needed early.

Any comments on that Paul? See also the two patches I'll post as a reply
to this thread make omap_hwmod_late_init a core_initcall.

The issue for omap4 still needs to be sorted out. And then we can 
see which omap initcalls really need to be core_initcalls.

Regards,

Tony

  reply	other threads:[~2011-01-25  2:21 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-23 17:13 [PATCH] ARM: OMAP2: use early init hook Russell King - ARM Linux
2011-01-23 17:13 ` Russell King - ARM Linux
2011-01-23 17:48 ` Russell King - ARM Linux
2011-01-23 17:48   ` Russell King - ARM Linux
2011-01-24 20:17   ` Tony Lindgren
2011-01-24 20:17     ` Tony Lindgren
2011-01-24 20:26     ` Tony Lindgren
2011-01-24 20:26       ` Tony Lindgren
2011-01-24 21:52       ` Russell King - ARM Linux
2011-01-24 21:52         ` Russell King - ARM Linux
2011-01-25  2:21         ` Tony Lindgren [this message]
2011-01-25  2:21           ` Tony Lindgren
2011-01-25  2:24           ` [PATCH] omap2+: Make omap_hwmod_late_init into core_initcall Tony Lindgren
2011-01-25  2:24             ` Tony Lindgren
2011-01-25  2:25           ` [PATCH] omap2+: Fix omap_serial_early_init to work with init_early hook Tony Lindgren
2011-01-25  2:25             ` Tony Lindgren
2011-01-27 18:01             ` Kevin Hilman
2011-01-27 18:01               ` Kevin Hilman
2011-01-25 19:27           ` [PATCH] omap: hwmod: Populate _mpu_rt_va later on in omap_hwmod_late_init Tony Lindgren
2011-01-25 19:27             ` Tony Lindgren
2011-01-25 19:29           ` [PATCH] ARM: OMAP2: use early init hook Tony Lindgren
2011-01-25 19:29             ` Tony Lindgren
2011-01-25 15:46     ` Poddar, Sourav
2011-01-25 15:46       ` Poddar, Sourav
2011-01-25 19:28       ` Tony Lindgren
2011-01-25 19:28         ` Tony Lindgren
2011-01-26 10:16         ` Poddar, Sourav
2011-01-26 10:16           ` Poddar, Sourav
2011-02-14 23:45     ` Tony Lindgren
2011-02-14 23:45       ` Tony Lindgren
2011-02-14 23:52       ` [PATCH] omap: Move omap2_check_revision and omap_sram_init out of map_io Tony Lindgren
2011-02-14 23:52         ` Tony Lindgren
2011-02-15  1:53         ` Tony Lindgren
2011-02-15  1:53           ` Tony Lindgren
2011-02-16 17:20           ` Tony Lindgren
2011-02-16 17:20             ` Tony Lindgren
2011-01-24 20:19 ` [PATCH] ARM: OMAP2: use early init hook Tony Lindgren
2011-01-24 20:19   ` Tony Lindgren
2011-01-26  8:46 ` Uwe Kleine-König
2011-01-26  8:46   ` Uwe Kleine-König
2011-01-26  8:52   ` Russell King - ARM Linux
2011-01-26  8:52     ` Russell King - ARM Linux
2011-01-26  9:11     ` Uwe Kleine-König
2011-01-26  9:11       ` Uwe Kleine-König
2011-01-26 10:31       ` Russell King - ARM Linux
2011-01-26 10:31         ` Russell King - ARM Linux
2011-02-07 15:35         ` [PATCH 1/4] ARM: imx: use .init_early to initialize cpu type and reset address Uwe Kleine-König
2011-02-07 15:35         ` [PATCH 2/4] ARM: mx3: use .init_early to initialize cpu type, reset address and iomuxer Uwe Kleine-König
2011-02-07 15:35         ` [PATCH 3/4] ARM: mx5: " Uwe Kleine-König
2011-02-07 15:35         ` [PATCH 4/4] ARM: mxc91231: use .init_early to initialize cpu type Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110125022119.GG13589@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=paul@pwsan.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.