From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 25 Jan 2011 07:51:04 +0000 Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support Message-Id: <20110125075104.GJ11673@linux-sh.org> List-Id: References: <1291451028-22532-1-git-send-email-hs@denx.de> <1295863047-11131-1-git-send-email-hs@denx.de> In-Reply-To: <1295863047-11131-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Heiko Schocher Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Samuel Ortiz , Vincent Sanders , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Randy Dunlap , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote: > @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev) > > if (info->pdata = NULL) { > dev_info(dev, "using default configuration data\n"); > - info->pdata = &sm501fb_def_pdata; > } > > /* probe for the presence of each panel */ I assume this is accidental? I don't see how you're compensating for this in any of the other patches at least, as it's orthogonal from the default mode settings. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from master.linux-sh.org (124x34x33x190.ap124.ftth.ucom.ne.jp [124.34.33.190]) by ozlabs.org (Postfix) with ESMTP id 2C5A21007D4 for ; Tue, 25 Jan 2011 18:51:14 +1100 (EST) Date: Tue, 25 Jan 2011 16:51:04 +0900 From: Paul Mundt To: Heiko Schocher Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support Message-ID: <20110125075104.GJ11673@linux-sh.org> References: <1291451028-22532-1-git-send-email-hs@denx.de> <1295863047-11131-1-git-send-email-hs@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1295863047-11131-1-git-send-email-hs@denx.de> Cc: linux-fbdev@vger.kernel.org, devicetree-discuss@ozlabs.org, Samuel Ortiz , Vincent Sanders , linux-kernel@vger.kernel.org, Ben Dooks , Randy Dunlap , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote: > @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev) > > if (info->pdata == NULL) { > dev_info(dev, "using default configuration data\n"); > - info->pdata = &sm501fb_def_pdata; > } > > /* probe for the presence of each panel */ I assume this is accidental? I don't see how you're compensating for this in any of the other patches at least, as it's orthogonal from the default mode settings. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752559Ab1AYHvP (ORCPT ); Tue, 25 Jan 2011 02:51:15 -0500 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:33529 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499Ab1AYHvO (ORCPT ); Tue, 25 Jan 2011 02:51:14 -0500 Date: Tue, 25 Jan 2011 16:51:04 +0900 From: Paul Mundt To: Heiko Schocher Cc: linuxppc-dev@lists.ozlabs.org, linux-fbdev@vger.kernel.org, devicetree-discuss@ozlabs.org, Ben Dooks , Vincent Sanders , Samuel Ortiz , linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support Message-ID: <20110125075104.GJ11673@linux-sh.org> References: <1291451028-22532-1-git-send-email-hs@denx.de> <1295863047-11131-1-git-send-email-hs@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1295863047-11131-1-git-send-email-hs@denx.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote: > @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev) > > if (info->pdata == NULL) { > dev_info(dev, "using default configuration data\n"); > - info->pdata = &sm501fb_def_pdata; > } > > /* probe for the presence of each panel */ I assume this is accidental? I don't see how you're compensating for this in any of the other patches at least, as it's orthogonal from the default mode settings. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Subject: Re: [PATCH 2/4 v4] video, sm501: add edid and commandline support Date: Tue, 25 Jan 2011 16:51:04 +0900 Message-ID: <20110125075104.GJ11673@linux-sh.org> References: <1291451028-22532-1-git-send-email-hs@denx.de> <1295863047-11131-1-git-send-email-hs@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1295863047-11131-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Heiko Schocher Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, Samuel Ortiz , Vincent Sanders , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Randy Dunlap , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, Jan 24, 2011 at 10:57:27AM +0100, Heiko Schocher wrote: > @@ -1884,7 +1935,6 @@ static int __devinit sm501fb_probe(struct platform_device *pdev) > > if (info->pdata == NULL) { > dev_info(dev, "using default configuration data\n"); > - info->pdata = &sm501fb_def_pdata; > } > > /* probe for the presence of each panel */ I assume this is accidental? I don't see how you're compensating for this in any of the other patches at least, as it's orthogonal from the default mode settings.