From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/10] autotools: allow host package to use <pkg>_MAKE_ENV and <pkg>_MAKE
Date: Tue, 25 Jan 2011 08:55:33 +0100 [thread overview]
Message-ID: <20110125085533.35bd27e1@surf> (raw)
In-Reply-To: <87ei82qaho.fsf@macbook.be.48ers.dk>
On Mon, 24 Jan 2011 22:04:35 +0100
Peter Korsgaard <jacmet@uclibc.org> wrote:
> Hmm, I don't really like this. Packages might be adding target specific
> stuff to their $PKG_MAKE_ENV - E.G.:
>
> lvm2/lvm2.mk:LVM2_MAKE_ENV = CC="$(TARGET_CC)"
>
> Wouldn't it make more sense to add a HOST_$PKG_MAKE_ENV and use it just
> like we do for $PKG_MAKE_ENV (E.G. at build and install time)?
$$(PKG) is already HOST_FOOBAR. So, when I do:
$(HOST_MAKE_ENV) $$($$(PKG)_MAKE_ENV) $$($$(PKG)_MAKE) -C $$($$(PKG)_SRCDIR) install
it gets expanded to
$(HOST_MAKE_ENV) $(HOST_<pkg>_MAKE_ENV) $(HOST_<pkg>_MAKE) -C $(HOST_<pkg>_SRCDIR) install
See how $(PKG) is defined:
$$($(2)_TARGET_INSTALL_HOST): PKG=$(2)
And $(2) is :
# argument 2 is the uppercase package name, including an HOST_ prefix
# for host packages
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-01-25 7:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 11:01 [Buildroot] [pull request] Pull request for branch for-2011.02/python-bump Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 01/10] python: Move to version 2.7 Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 02/10] python: Port the python2.4 patches to 2.7 Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 03/10] python: Add the needed patches to compile python2.7 in buildroot Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 04/10] python: Fix make install (Workaround python's bug #1669349) Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 05/10] libffi: new package Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 06/10] autotools: allow host package to use <pkg>_MAKE_ENV and <pkg>_MAKE Thomas Petazzoni
2011-01-24 21:04 ` Peter Korsgaard
2011-01-25 7:55 ` Thomas Petazzoni [this message]
2011-01-25 9:02 ` Peter Korsgaard
2011-01-24 11:01 ` [Buildroot] [PATCH 07/10] python: convert to autotargets, bump to 2.7.1, many improvements Thomas Petazzoni
2011-01-24 11:01 ` [Buildroot] [PATCH 08/10] Remove .py or .pyc depending on Python configuration Thomas Petazzoni
2011-01-24 21:20 ` Peter Korsgaard
2011-01-24 11:01 ` [Buildroot] [PATCH 09/10] python-serial: new package Thomas Petazzoni
2011-01-24 21:22 ` Peter Korsgaard
2011-01-24 11:01 ` [Buildroot] [PATCH 10/10] python-mad: " Thomas Petazzoni
2011-01-24 21:23 ` Peter Korsgaard
2011-01-25 8:03 ` [Buildroot] [pull request] Pull request for branch for-2011.02/python-bump Thomas Petazzoni
2011-01-25 21:17 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125085533.35bd27e1@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.