diff for duplicates of <20110125090203.GA17883@linux-sh.org> diff --git a/a/1.txt b/N1/1.txt index 11d000c..d2f5e22 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -79,14 +79,14 @@ paths, so it's safe to always reference them. > + int i; > + > + for (i = 0; i <= 10; i++) { -> + if (info->var.xres = unifb_modes[i].xres -> + && info->var.yres = unifb_modes[i].yres -> + && info->var.upper_margin = unifb_modes[i].upper_margin -> + && info->var.lower_margin = unifb_modes[i].lower_margin -> + && info->var.left_margin = unifb_modes[i].left_margin -> + && info->var.right_margin = unifb_modes[i].right_margin -> + && info->var.hsync_len = unifb_modes[i].hsync_len -> + && info->var.vsync_len = unifb_modes[i].vsync_len) { +> + if (info->var.xres == unifb_modes[i].xres +> + && info->var.yres == unifb_modes[i].yres +> + && info->var.upper_margin == unifb_modes[i].upper_margin +> + && info->var.lower_margin == unifb_modes[i].lower_margin +> + && info->var.left_margin == unifb_modes[i].left_margin +> + && info->var.right_margin == unifb_modes[i].right_margin +> + && info->var.hsync_len == unifb_modes[i].hsync_len +> + && info->var.vsync_len == unifb_modes[i].vsync_len) { > + pixclk = unifb_modes[i].pixclock; > + break; > + } @@ -103,11 +103,11 @@ You'll presumably also want to check if clk_get() returned an error and handle that accordingly. > + if (pixclk != 0) { -> + if (clk_set_rate(clk_vga, pixclk) = 0) +> + if (clk_set_rate(clk_vga, pixclk) == 0) > + i = 1; > + } > + -> + if (i = 0) { /* set clock failed */ +> + if (i == 0) { /* set clock failed */ > + info->fix = unifb_fix; > + info->var = unifb_default; > + clk_set_rate(clk_vga, unifb_default.pixclock); @@ -117,7 +117,7 @@ If clk_set_rate() can fail the first time, it can fail the second time too. You'll want more error handling here. > + /* Truecolor has hardware independent palette */ -> + if (info->fix.visual = FB_VISUAL_TRUECOLOR) { +> + if (info->fix.visual == FB_VISUAL_TRUECOLOR) { > + u32 v; > + > + if (regno >= 16) @@ -229,12 +229,12 @@ What happened to FBINFO_HWACCEL_IMAGEBLIT? > +{ > + int rc = 0; > + -> + if (dev->dev.power.power_state.event = PM_EVENT_ON) +> + if (dev->dev.power.power_state.event == PM_EVENT_ON) > + return 0; > + > + acquire_console_sem(); > + -> + if (dev->dev.power.power_state.event = PM_EVENT_SUSPEND) { +> + if (dev->dev.power.power_state.event == PM_EVENT_SUSPEND) { > + UDE_FSA = unifb_regs[0]; > + UDE_LS = unifb_regs[1]; > + UDE_PS = unifb_regs[2]; diff --git a/a/content_digest b/N1/content_digest index b463325..b0bd187 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\001cf01cbba1f$49f84130$dde8c390$@mprc.pku.edu.cn\0" "From\0Paul Mundt <lethal@linux-sh.org>\0" "Subject\0Re: [PATCH] unicore32: add framebuffer driver for unigfx engine in PKUnity SoC\0" - "Date\0Tue, 25 Jan 2011 09:02:04 +0000\0" + "Date\0Tue, 25 Jan 2011 18:02:04 +0900\0" "To\0Guan Xuetao <guanxuetao@mprc.pku.edu.cn>\0" "Cc\0linux-fbdev@vger.kernel.org" " linux-kernel@vger.kernel.org\0" @@ -88,14 +88,14 @@ "> +\tint i;\n" "> +\n" "> +\tfor (i = 0; i <= 10; i++) {\n" - "> +\t\tif (info->var.xres = unifb_modes[i].xres\n" - "> +\t\t && info->var.yres = unifb_modes[i].yres\n" - "> +\t\t && info->var.upper_margin = unifb_modes[i].upper_margin\n" - "> +\t\t && info->var.lower_margin = unifb_modes[i].lower_margin\n" - "> +\t\t && info->var.left_margin = unifb_modes[i].left_margin\n" - "> +\t\t && info->var.right_margin = unifb_modes[i].right_margin\n" - "> +\t\t && info->var.hsync_len = unifb_modes[i].hsync_len\n" - "> +\t\t && info->var.vsync_len = unifb_modes[i].vsync_len) {\n" + "> +\t\tif (info->var.xres == unifb_modes[i].xres\n" + "> +\t\t && info->var.yres == unifb_modes[i].yres\n" + "> +\t\t && info->var.upper_margin == unifb_modes[i].upper_margin\n" + "> +\t\t && info->var.lower_margin == unifb_modes[i].lower_margin\n" + "> +\t\t && info->var.left_margin == unifb_modes[i].left_margin\n" + "> +\t\t && info->var.right_margin == unifb_modes[i].right_margin\n" + "> +\t\t && info->var.hsync_len == unifb_modes[i].hsync_len\n" + "> +\t\t && info->var.vsync_len == unifb_modes[i].vsync_len) {\n" "> +\t\t\tpixclk = unifb_modes[i].pixclock;\n" "> +\t\t\tbreak;\n" "> +\t\t}\n" @@ -112,11 +112,11 @@ "handle that accordingly.\n" "\n" "> +\tif (pixclk != 0) {\n" - "> +\t\tif (clk_set_rate(clk_vga, pixclk) = 0)\n" + "> +\t\tif (clk_set_rate(clk_vga, pixclk) == 0)\n" "> +\t\t\ti = 1;\n" "> +\t}\n" "> +\n" - "> +\tif (i = 0) { /* set clock failed */\n" + "> +\tif (i == 0) { /* set clock failed */\n" "> +\t\tinfo->fix = unifb_fix;\n" "> +\t\tinfo->var = unifb_default;\n" "> +\t\tclk_set_rate(clk_vga, unifb_default.pixclock);\n" @@ -126,7 +126,7 @@ "too. You'll want more error handling here.\n" "\n" "> +\t/* Truecolor has hardware independent palette */\n" - "> +\tif (info->fix.visual = FB_VISUAL_TRUECOLOR) {\n" + "> +\tif (info->fix.visual == FB_VISUAL_TRUECOLOR) {\n" "> +\t\tu32 v;\n" "> +\n" "> +\t\tif (regno >= 16)\n" @@ -238,12 +238,12 @@ "> +{\n" "> +\tint rc = 0;\n" "> +\n" - "> +\tif (dev->dev.power.power_state.event = PM_EVENT_ON)\n" + "> +\tif (dev->dev.power.power_state.event == PM_EVENT_ON)\n" "> +\t\treturn 0;\n" "> +\n" "> +\tacquire_console_sem();\n" "> +\n" - "> +\tif (dev->dev.power.power_state.event = PM_EVENT_SUSPEND) {\n" + "> +\tif (dev->dev.power.power_state.event == PM_EVENT_SUSPEND) {\n" "> +\t\tUDE_FSA = unifb_regs[0];\n" "> +\t\tUDE_LS = unifb_regs[1];\n" "> +\t\tUDE_PS = unifb_regs[2];\n" @@ -317,4 +317,4 @@ "\n" No need for the ifdef here, either. -d102906919a06c44dfc778afb7ceb0b55e54a3a788b60f5a3850092e26953a24 +1c60532408854f126399dc644a4ac807dc3d68a13ff1c1f5f5aed6f806dc939d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.