All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] lis33: turn down the no IRQ message
Date: Tue, 25 Jan 2011 16:16:50 +0000	[thread overview]
Message-ID: <20110125161650.GA7999@ericsson.com> (raw)
In-Reply-To: <20110125150910.18731.92369.stgit@bob.linux.org.uk>

On Tue, Jan 25, 2011 at 11:05:54AM -0500, Alan Cox wrote:
> On Tue, 25 Jan 2011 07:53:01 -0800
> Guenter Roeck <guenter.roeck@ericsson.com> wrote:
> 
> > On Tue, Jan 25, 2011 at 10:09:15AM -0500, Alan Cox wrote:
> > > From: Kalhan Trisal <kalhan.trisal@intel.com>
> > > 
> > > Turn down the no IRQ message - on some platforms that's a normal state of
> > > affairs.
> > > 
> > > Signed-off-by: Kalhan Trisal <kalhan.trisal@intel.com>
> > > Signed-off-by: Alan Cox <alan@linux.intel.com>
> > 
> > Wondering - pr_err was too strong, but maybe pr_info would make sense
> > to inform the user that /dev/freefall won't work. Otherwise we may get
> > support requests with people complaining about it, and we won't be able
> > to see the reason.
> > 
> > Thoughts ?
> 
> That or pass whether /dev/freefall is wanted in the platform data
> somewhere ?
> 
> Basically though if dev->irq is not set it means there is no IRQ, and
> that isn't neccessarily an error.
> 
Difference is developer knowledge (no irq) vs. user understanding. Sure, no irq 
implies no freefall, and that is not an error. However, the user won't know that,
and thus might appreciate a note.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-01-25 16:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 15:09 [lm-sensors] [PATCH] lis33: turn down the no IRQ message Alan Cox
2011-01-25 15:53 ` Guenter Roeck
2011-01-25 16:16 ` Guenter Roeck [this message]
2011-01-25 16:22 ` Guenter Roeck
2011-01-25 16:22 ` Guenter Roeck
2011-01-25 16:25 ` Éric Piel
2011-01-25 16:34 ` Jean Delvare
2011-01-25 16:35 ` Guenter Roeck
2011-01-25 16:41 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110125161650.GA7999@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.