From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] lis33: turn down the no IRQ message
Date: Tue, 25 Jan 2011 16:41:36 +0000 [thread overview]
Message-ID: <20110125164136.GA8213@ericsson.com> (raw)
In-Reply-To: <20110125150910.18731.92369.stgit@bob.linux.org.uk>
On Tue, Jan 25, 2011 at 11:34:53AM -0500, Jean Delvare wrote:
> On Tue, 25 Jan 2011 07:53:01 -0800, Guenter Roeck wrote:
> > On Tue, Jan 25, 2011 at 10:09:15AM -0500, Alan Cox wrote:
> > > From: Kalhan Trisal <kalhan.trisal@intel.com>
> > >
> > > Turn down the no IRQ message - on some platforms that's a normal state of
> > > affairs.
> > >
> > > Signed-off-by: Kalhan Trisal <kalhan.trisal@intel.com>
> > > Signed-off-by: Alan Cox <alan@linux.intel.com>
> >
> > Wondering - pr_err was too strong, but maybe pr_info would make sense
> > to inform the user that /dev/freefall won't work. Otherwise we may get
> > support requests with people complaining about it, and we won't be able
> > to see the reason.
> >
> > Thoughts ?
>
> The comment says: "on some platforms that's a normal state of affairs".
> So it's down to: can there be other reasons to the missing IRQ than
> these platforms where we expect it? If not, then pr_debug() is right.
> If there is, then we need separate messages for the expected and
> unexpected cases.
>
I don't think there can be other reasons, unless there is a bug somewhere,
which of course is always possible. Only reason for bringing it up was that
someone had complained about the missing /dev/freefall a couple of months ago.
Anyway, since Eric is fine with pr_debug, let's stick with it.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2011-01-25 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 15:09 [lm-sensors] [PATCH] lis33: turn down the no IRQ message Alan Cox
2011-01-25 15:53 ` Guenter Roeck
2011-01-25 16:16 ` Guenter Roeck
2011-01-25 16:22 ` Guenter Roeck
2011-01-25 16:22 ` Guenter Roeck
2011-01-25 16:25 ` Éric Piel
2011-01-25 16:34 ` Jean Delvare
2011-01-25 16:35 ` Guenter Roeck
2011-01-25 16:41 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125164136.GA8213@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.