Re: [PATCH net-next-2.6] bonding: fix return value of bonding_store_slaves_active()

[Jiri Pirko <jpirko@redhat.com>]

Tue, Jan 25, 2011 at 08:22:50PM CET, fubar@us.ibm.com wrote:
>Jiri Pirko <jpirko@redhat.com> wrote:
>
>>count is incorrectly returned even in case of fail. Return ret instead.
>>
>>Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
>	It looks like bonding_store_carrier has the same problem, could
>you fix it up too and resubmit?

you are right, I missed that. Will resend.

Thanks.

Jirka
>
>	-J
>
>
>>diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c
>>index 8fd0174..f33155f 100644
>>--- a/drivers/net/bonding/bond_sysfs.c
>>+++ b/drivers/net/bonding/bond_sysfs.c
>>@@ -1595,7 +1595,7 @@ static ssize_t bonding_store_slaves_active(struct device *d,
>> 		}
>> 	}
>> out:
>>-	return count;
>>+	return ret;
>> }
>> static DEVICE_ATTR(all_slaves_active, S_IRUGO | S_IWUSR,
>> 		   bonding_show_slaves_active, bonding_store_slaves_active);
>