From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
john.r.fastabend@intel.com
Subject: Re: [PATCH net-next-2.6] net_sched: sch_mqprio: dont leak kernel memory
Date: Wed, 26 Jan 2011 11:56:04 -0800 (PST) [thread overview]
Message-ID: <20110126.115604.71133457.davem@davemloft.net> (raw)
In-Reply-To: <1296064578.6115.39.camel@Joe-Laptop>
From: Joe Perches <joe@perches.com>
Date: Wed, 26 Jan 2011 09:56:18 -0800
> On Wed, 2011-01-26 at 18:49 +0100, Eric Dumazet wrote:
>> Le mercredi 26 janvier 2011 à 09:43 -0800, Joe Perches a écrit :
>> > I think the best style to use memset so that any
>> > possible struct padding is guaranteed to be zeroed.
>> We use the { 0 } style in net/sched,
>
> That's nice, but it's the wrong style.
> https://lkml.org/lkml/2010/12/15/63
>
>> and there is no padding in this
>> structure, I checked this point.
>
> That may be true right now for this particular
> structure, but that style is not future-proof.
It is future-proof if the data-structure is user-visible and therefore
will never change, as is the case here.
next prev parent reply other threads:[~2011-01-26 19:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 17:21 [PATCH net-next-2.6] net_sched: sch_mqprio: dont leak kernel memory Eric Dumazet
2011-01-26 17:43 ` Joe Perches
2011-01-26 17:49 ` Eric Dumazet
2011-01-26 17:56 ` Joe Perches
2011-01-26 19:56 ` David Miller [this message]
2011-01-27 11:17 ` Pádraig Brady
2011-01-26 19:55 ` David Miller
2011-01-26 20:23 ` Eric Dumazet
2011-01-26 20:25 ` Eric Dumazet
2011-01-26 21:24 ` Joe Perches
2011-01-26 21:28 ` Eric Dumazet
2011-01-26 21:33 ` Joe Perches
2011-01-27 6:04 ` Joe Perches
2011-01-27 6:54 ` Changli Gao
2011-01-27 7:04 ` Eric Dumazet
2011-01-26 21:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126.115604.71133457.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.