From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753043Ab1AZK4u (ORCPT ); Wed, 26 Jan 2011 05:56:50 -0500 Received: from cantor.suse.de ([195.135.220.2]:45199 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752720Ab1AZK4t (ORCPT ); Wed, 26 Jan 2011 05:56:49 -0500 Date: Wed, 26 Jan 2011 18:15:56 +0800 From: Greg KH To: Bob Liu Cc: "Berg, Johannes" , "linux-kernel@vger.kernel.org" , "chrisw@sous-sol.org" , "Winkler, Tomas" , "dmitry.torokhov@gmail.com" Subject: Re: [PATCH] firmware_classs: change val uevent's type to bool Message-ID: <20110126101556.GA16446@suse.de> References: <1296036004-15644-1-git-send-email-lliubbo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2011 at 06:03:32PM +0800, Bob Liu wrote: > On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes wrote: > > @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, > >        f_dev->parent = device; > >        f_dev->class = &firmware_class; > > > > -       dev_set_uevent_suppress(f_dev, true); > > +       if (uevent) > > +               dev_set_uevent_suppress(f_dev, true); > > > > Everything but this is a no-op basically, but you didn't even describe this change? > > > > > Hmm.. Sorry for that, but I mentioned that by "fix a place missing > uevent check". > I added this check because I think it should be paired with following > dev_set_uevent_suppress(f_dev, false). That's fine, but please, split that out into a separate patch. Remember, a patch should only do one thing. Please resend this as two patches and I will be glad to queue it up. thanks, greg k-h