All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Keir Fraser <keir@xen.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: xenstore index reset in xb_init_comms breaks domU kdump
Date: Wed, 26 Jan 2011 15:30:47 +0100	[thread overview]
Message-ID: <20110126143047.GA29825@aepfle.de> (raw)
In-Reply-To: <C965DE5E.127A2%keir@xen.org>

On Wed, Jan 26, Keir Fraser wrote:

> I think it is needed for save/restore. It may not be needed during boot
> though. Your safest (lowest impact) fix would be to skip the reset when
> booting a crash kernel. A kernel knows it is a crash kernel, I believe?

There is is is_kdump_kernel(), which relies on an unexported variable.
However, the kdump tool in SLES11 passes 'reset_devices' in cmdline. And
this variable is exported and used in a few drivers to do extra hardware
reset. My patch adds a if (!reset_devices) before the assignment.

reset_devices was added in commit
7e96287ddc4f42081e18248b6167041c0908004c and appeared in 2.6.19. Its not
yet part of linux-2.6.18-xen.hg, it should be easy to backport.

I will post my SLES11 SP1 version of the kdump patch shortly.

Olaf

      reply	other threads:[~2011-01-26 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 14:00 xenstore index reset in xb_init_comms breaks domU kdump Olaf Hering
2011-01-26 14:21 ` Keir Fraser
2011-01-26 14:30   ` Olaf Hering [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110126143047.GA29825@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.