From: Jarkko Nikula <jhnikula@gmail.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Harsha Priya <priya.harsha@intel.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing
Date: Wed, 26 Jan 2011 16:28:01 +0200 [thread overview]
Message-ID: <20110126162801.b53e4cdf.jhnikula@gmail.com> (raw)
In-Reply-To: <1296043097-11720-1-git-send-email-jhnikula@gmail.com>
On Wed, 26 Jan 2011 13:58:14 +0200
Jarkko Nikula <jhnikula@gmail.com> wrote:
> Commit f6c2ed5 "ASoC: Fix the device references to codec and platform drivers"
> moved codec and platform driver refcount increments from soc_bind_dai_link
> to more appropriate places.
>
> Adjust a little them so that refcounts are incremented before executing the
> driver probe functions.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Harsha Priya <priya.harsha@intel.com>
> ---
> I don't know any regression with this so probably 2.6.39 material.
> ---
Actually I found a regression that I like to fix before this. There's a
try_module_get in soc_probe_aux_dev that the commit f6c2ed5 didn't
remove and for auxialiry devices there will be then two try_module_get
calls since another is in soc_probe_codec.
--
Jarkko
prev parent reply other threads:[~2011-01-26 14:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 11:58 [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
2011-01-26 11:58 ` [PATCH 2/4] ASoC: Add optional pointer to machine audio routes to snd_soc_card Jarkko Nikula
2011-01-26 13:35 ` Mark Brown
2011-01-26 11:58 ` [PATCH 3/4] ASoC: Add optional pointer to codec interconnects to snd_soc_codec_driver Jarkko Nikula
2011-01-26 13:41 ` Mark Brown
2011-01-26 11:58 ` [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration Jarkko Nikula
2011-01-26 13:28 ` Mark Brown
2011-01-26 13:41 ` Jarkko Nikula
2011-01-27 6:57 ` Peter Ujfalusi
2011-01-27 7:21 ` Jarkko Nikula
2011-01-27 9:58 ` Mark Brown
2011-01-26 14:28 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126162801.b53e4cdf.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.