From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] compile time initialization for event flags value
Date: Wed, 26 Jan 2011 18:19:41 +0100 [thread overview]
Message-ID: <20110126171939.GC1757@nowhere> (raw)
In-Reply-To: <4D3FDFFC.6030304@cn.fujitsu.com>
On Wed, Jan 26, 2011 at 04:49:00PM +0800, Lai Jiangshan wrote:
> compile time initialization is better than runtime initialization.
>
> impact: remove many early_initcall()s and many trace_init_flags_##name()s.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> ---
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index 18cd068..ff074c8 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -135,8 +135,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
> .class = &event_class_syscall_enter, \
> .event.funcs = &enter_syscall_print_funcs, \
> .data = (void *)&__syscall_meta_##sname,\
> - }; \
> - __TRACE_EVENT_FLAGS(enter_##sname, TRACE_EVENT_FL_CAP_ANY)
> + .flags = TRACE_EVENT_FL_CAP_ANY, \
> + };
>
> #define SYSCALL_TRACE_EXIT_EVENT(sname) \
> static struct syscall_metadata \
> @@ -149,8 +149,8 @@ extern struct trace_event_functions exit_syscall_print_funcs;
> .class = &event_class_syscall_exit, \
> .event.funcs = &exit_syscall_print_funcs, \
> .data = (void *)&__syscall_meta_##sname,\
> - }; \
> - __TRACE_EVENT_FLAGS(exit_##sname, TRACE_EVENT_FL_CAP_ANY)
> + .flags = TRACE_EVENT_FL_CAP_ANY, \
> + };
>
> #define SYSCALL_METADATA(sname, nb) \
> SYSCALL_TRACE_ENTER_EVENT(sname); \
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
next prev parent reply other threads:[~2011-01-26 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 8:49 [PATCH] compile time initialization for event flags value Lai Jiangshan
2011-01-26 17:19 ` Frederic Weisbecker [this message]
2011-02-17 15:01 ` [tip:perf/core] tracing: Compile " tip-bot for Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126171939.GC1757@nowhere \
--to=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.