From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] i2c_intel_mid: Improve error reporting
Date: Thu, 27 Jan 2011 00:44:23 +0000 [thread overview]
Message-ID: <20110127004422.GI15795@trinity.fluff.org> (raw)
In-Reply-To: <20110125142040.9472.88734.stgit-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
On Tue, Jan 25, 2011 at 02:20:48PM +0000, Alan Cox wrote:
> From: Catalin Popescu <catalinx.popescu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> The error messages printed from mrst_i2c_abort() didn't give slave address info.
>
> But I2C device driver developers always need this to check which slave device
> has the problem.
Erm, surely the driver itself should know what i2c device it is communicating
with? Secondly, does this swamp the kernel dmesg buffer when run with the
i2c-detect tool?
> This patch enhances the error message format by adding slave address info to
> each error message.
Why not use dev_err() on the i2c device's device state?
--
Ben Dooks, ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-01-27 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 14:20 [PATCH 1/3] i2c_intel_mid: Improve error reporting Alan Cox
[not found] ` <20110125142040.9472.88734.stgit-Z/y2cZnRghHXmaaqVzeoHQ@public.gmane.org>
2011-01-25 14:21 ` [PATCH 2/3] i2c-intel-mid: improve timeout handling Alan Cox
2011-01-25 14:22 ` [PATCH 3/3] MID I2C runtime PM Alan Cox
2011-01-27 0:44 ` Ben Dooks [this message]
[not found] ` <20110127004422.GI15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-01-27 11:33 ` [PATCH 1/3] i2c_intel_mid: Improve error reporting Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127004422.GI15795@trinity.fluff.org \
--to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
--cc=alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.