From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41210 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PiML1-0007Pp-Qf
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 02:32:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PiMKz-0002FZ-6l
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 02:32:15 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28146)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1PiMKy-0002EG-Vz
	for qemu-devel@nongnu.org; Thu, 27 Jan 2011 02:32:13 -0500
Date: Thu, 27 Jan 2011 09:31:56 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20110127073156.GB28784@redhat.com>
References: <cover.1296111201.git.yamahata@valinux.co.jp>
	<bd7f33e8c88e87971f4eaeacf4432729f53e86c5.1296111201.git.yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd7f33e8c88e87971f4eaeacf4432729f53e86c5.1296111201.git.yamahata@valinux.co.jp>
Subject: [Qemu-devel] Re: [PATCH v2 4/5] pci: use PCI_SLOT in
	pci_get_bus_devfn()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org

On Thu, Jan 27, 2011 at 03:56:38PM +0900, Isaku Yamahata wrote:
> use PCI_SLOT in pci_get_bus_devfn().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Tweaked the comment and applied.

> ---
>  hw/pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index 471d4d7..e25bf7a 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -558,7 +558,7 @@ PCIBus *pci_get_bus_devfn(int *devfnp, const char *devaddr)
>          return NULL;
>      }
>  
> -    *devfnp = slot << 3;
> +    *devfnp = PCI_DEVFN(slot, 0);
>      return pci_find_bus(pci_find_root_bus(dom), bus);
>  }
>  
> -- 
> 1.7.1.1