All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Olivier DANET" <odanet@caramail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] ESP : Fix status register update
Date: Thu, 27 Jan 2011 20:06:48 +0100	[thread overview]
Message-ID: <20110127190648.245680@gmx.com> (raw)


The Count to zero flag (STAT_TC) must not be cleared after an Interrupt Status
register read.

Signed-off-by: Olivier Danet <odanet@caramail.com>
---
 hw/esp.c     2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/esp.c b/hw/esp.c
index fa9d2a2..90bfdc6 100644
--- a/hw/esp.c
+++ b/hw/esp.c
@@ -525,9 +525,9 @@ static uint32_t esp_mem_readb(void *opaque, target_phys_addr_t addr)
            except TC */
         old_val = s->rregs[ESP_RINTR];
         s->rregs[ESP_RINTR] = 0;
-        s->rregs[ESP_RSTAT] &= ~STAT_TC;
         s->rregs[ESP_RSEQ] = SEQ_CD;
         esp_lower_irq(s);
+        s->rregs[ESP_RSTAT] &= STAT_TC  STAT_MI;
 
         return old_val;
     default:
-- 
1.6.2.4

             reply	other threads:[~2011-01-27 19:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 19:06 Olivier DANET [this message]
2011-01-28 21:09 ` [Qemu-devel] [PATCH] ESP : Fix status register update Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110127190648.245680@gmx.com \
    --to=odanet@caramail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.