From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Huang Ying <ying.huang@intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Avi Kivity <avi@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
Dean Nelson <dnelson@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/2] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally
Date: Fri, 28 Jan 2011 08:39:09 +0100 [thread overview]
Message-ID: <20110128073909.GC15569@one.firstfloor.org> (raw)
In-Reply-To: <20110127171244.7a9442a7.akpm@linux-foundation.org>
> > Also longer term we'll get compilers that can do cross-file inlining
> > for optimized builds.
>
> Which we'll probably need to turn off all over the place :(
Why?
>
> > So please better avoid these kinds of micro optimizations unless
> > it's a really really extremly speed critical path.
>
> It's not just speed and it's not just .text size, either. Calling a
> ten-arg function consumes stack space.
gcc is pretty good at handling tail calls. Take a look at the code
it generates.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2011-01-28 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 8:42 [PATCH 1/2] mm, Make __get_user_pages return -EHWPOISON for HWPOISON page optionally Huang Ying
2011-01-13 10:43 ` Avi Kivity
2011-01-14 1:37 ` Huang Ying
2011-01-16 15:35 ` Avi Kivity
2011-01-17 0:47 ` Huang Ying
2011-01-20 15:50 ` Marcelo Tosatti
2011-01-27 7:29 ` Huang Ying
2011-01-27 23:07 ` Andrew Morton
2011-01-28 0:57 ` Andi Kleen
2011-01-28 1:12 ` Andrew Morton
2011-01-28 7:39 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128073909.GC15569@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dnelson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.