From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58397 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PjCLB-0003ec-TU
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 10:03:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PjCL9-0008Tr-Ph
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 10:03:53 -0500
Received: from hall.aurel32.net ([88.191.126.93]:47639)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PjCL9-0008TH-LG
	for qemu-devel@nongnu.org; Sat, 29 Jan 2011 10:03:51 -0500
Date: Sat, 29 Jan 2011 16:03:42 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 1/2] prep: Remove bogus BIOS size check
Message-ID: <20110129150342.GE4213@ohm.aurel32.net>
References: <1295387036-16961-1-git-send-email-hpoussin@reactos.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1295387036-16961-1-git-send-email-hpoussin@reactos.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-15?Q?Herv=E9?= Poussineau <hpoussin@reactos.org>
Cc: Andreas =?iso-8859-15?Q?F=E4rber?= <andreas.faerber@web.de>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Tue, Jan 18, 2011 at 10:43:55PM +0100, Hervé Poussineau wrote:
> From: Andreas Färber <andreas.faerber@web.de>
> 
> r3480 added this check to account for the entry vector 0xfff00100 to be
> available for CPUs that need it. Today however, the NIP is not yet
> initialized at this point (zero), so the check always triggers.
> 
> Moreover, BIOS size check is already done previously, so this part can
> be removed too.
> 
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/ppc_prep.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)

Thanks, applied.

> diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
> index 1492266..6b22122 100644
> --- a/hw/ppc_prep.c
> +++ b/hw/ppc_prep.c
> @@ -600,9 +600,6 @@ static void ppc_prep_init (ram_addr_t ram_size,
>      if (filename) {
>          qemu_free(filename);
>      }
> -    if (env->nip < 0xFFF80000 && bios_size < 0x00100000) {
> -        hw_error("PowerPC 601 / 620 / 970 need a 1MB BIOS\n");
> -    }
>  
>      if (linux_boot) {
>          kernel_base = KERNEL_LOAD_ADDR;
> -- 
> 1.7.2.3
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net