From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Mon, 31 Jan 2011 22:34:34 +0100
Subject: [U-Boot] [PATCH0/6] patchset to support TPL and P1021MDS board
In-Reply-To: <20110131151506.700ddcd7@udp111988uds.am.freescale.net>
References: <1296499317-26616-1-git-send-email-Haiying.Wang@freescale.com>
	<20110131193951.52AEFD4D67C@gemini.denx.de>
	<20110131141332.5a4a297d@udp111988uds.am.freescale.net>
	<20110131202204.43504D4D67C@gemini.denx.de>
	<20110131143141.2959da63@udp111988uds.am.freescale.net>
	<20110131205057.19D1BD4D67C@gemini.denx.de>
	<20110131151506.700ddcd7@udp111988uds.am.freescale.net>
Message-ID: <20110131213434.B2FFED4D67C@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Scott Wood,

In message <20110131151506.700ddcd7@udp111988uds.am.freescale.net> you wrote:
> 
> > For example, why must we add the Makefile changes in the first step,
> > when all the code it references is still missing?  Should this not be
> > the last step?
> 
> If you make it the last step, then the board will exist but not be
> buildable in the previous step (unless you combine them, but you said
> that's not what you're asking for).  How is that better?  And is this
> really worth bickering about?

Yes, this is better, and this is how we always do it: add the featurs,
but not enable them unless we have all together, then add the needed
#defines and make rules to actually use the code.

> Please just say, clearly and specifically, what you want the patchset
> to look like...
> 
> > And what is the benefit of adding documentation to the README here?
> > To me it makes more sense to add this when CONFIG_HAS_TPL and
> > CONFIG_IN_TPL get used first.
> 
> Because it's not specific to 85xx or p1021mds.  The generic
> infrastructure for TPL consists of the makefile changes and
> documentation.  It seems useful to me to separate that for review, but

A dead / broken make rule and dead documentation is what the generic
infrastructure for TPL consists of?

> if you want it squashed into a board-specific patch instead, fine.
> Just tell us what you want to see.

I already did, but here we go:

First, please do not add make rules before you have code they apply
to.  After doing this, there is this rudimentary patch to the README.