From: Andrea Arcangeli <aarcange@redhat.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>
Subject: Re: wait_split_huge_page() dependence on rmap.h
Date: Tue, 1 Feb 2011 00:41:50 +0100 [thread overview]
Message-ID: <20110131234150.GR16981@random.random> (raw)
In-Reply-To: <1296516675.7797.5110.camel@nimitz>
On Mon, Jan 31, 2011 at 03:31:15PM -0800, Dave Hansen wrote:
> wait_split_huge_page() is really only used in a few spots at the moment.
> I was trying to use it in fs/proc/task_mmu.c, but simply including
> huge_mm.h gets this:
>
> fs/proc/task_mmu.c: In function a??smaps_pte_rangea??:
> fs/proc/task_mmu.c:392: error: dereferencing pointer to incomplete type
I like what you're doing eheh ;)
> I think it's due to the __anon_vma dereference below. #including rmap.h
> makes it go away, but I don't think it's really the correct thing to do
> here. Directly including rmap.h in huge_mm.h ends up with some really
> interesting header dependencies and does not work either.
>
> Any ideas? Should we move the existing huge_mm.h stuff to a private
> header and have a more public one that also brings in rmap.h?
Solution:
+#include <linux/rmap.h>
And avoid including an explicit #include huge_mm.h which is never
needed (not even huge_memory.c includes huge_mm.h, rmap.h is all you
need)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-01-31 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 23:31 wait_split_huge_page() dependence on rmap.h Dave Hansen
2011-01-31 23:41 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110131234150.GR16981@random.random \
--to=aarcange@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.