All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: dm-devel@redhat.com
Subject: Re: multipath: change the DEFAULT_MINIO for the request based multipath
Date: Mon, 31 Jan 2011 22:13:16 -0500	[thread overview]
Message-ID: <20110201031316.GA10957@redhat.com> (raw)
In-Reply-To: <20110201022120.GA24297@us.ibm.com>

On Mon, Jan 31 2011 at  9:21pm -0500,
Malahal Naineni <malahal@us.ibm.com> wrote:

> Christophe Varoqui [christophe.varoqui@gmail.com] wrote:
> > I pushed an implementation of the fully capable solution.
> > 
> > The behaviour is unchanged with dm-multipath <= 1.1.0
> > For newer driver, if no additional config is added to multipath.conf the
> > minio will be set to 1.
> > 
> > If Mike S. tests prove this value is not always optimal, it can be tuned
> > per device in hwtable (hwe->minio_rq) and overridden in multipath.conf
> > device{} and multipath{} section.
> > 
> > This seemed to be the most consistent behaviour, to me. But feel free to
> > disagree.
> > 
> > Please test carefully as the patch is quite invasive. I built and tested
> > lightly with a NetApp iSCSI simulator. The session produced the
> > following output
> 
> Where is the patch? I would like test it. I have a patch set that does
> what I said and was planning on adding a field to hwentry structure
> without adding a new config keyword in /etc/multipath.conf. It doesn't
> appear that big a change, but would like to see your patch.

Christophe committed it already, see the following multipath-tools
commit:
2b68b83 Support different 'minio' values for rq and bio based dm-multipath

  reply	other threads:[~2011-02-01  3:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 21:30 [PATCH] [RFC] multipath: change the DEFAULT_MINIO for the request based multipath Malahal Naineni
2011-01-20  7:32 ` Hannes Reinecke
2011-01-20 16:07   ` Mike Snitzer
2011-01-21  7:03     ` Jun'ichi Nomura
2011-01-21  8:47       ` Christophe Varoqui
2011-01-21 14:12         ` Mike Snitzer
2011-01-21 14:46           ` Christophe Varoqui
2011-01-21 17:39             ` Malahal Naineni
2011-01-25  8:56               ` Jun'ichi Nomura
2011-01-26  2:23                 ` Malahal Naineni
2011-01-26 17:27                   ` nishant mungse
2011-01-27 15:16                     ` nishant mungse
2011-01-31 23:53                   ` Christophe Varoqui
2011-02-01  2:21                     ` Malahal Naineni
2011-02-01  3:13                       ` Mike Snitzer [this message]
2011-02-01  8:14                         ` Malahal Naineni
2011-02-01  8:13                     ` Malahal Naineni
2011-02-01  9:00                       ` Christophe Varoqui
2011-02-01  9:51                         ` Malahal Naineni
2011-01-21 13:26       ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201031316.GA10957@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.