From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Amstrad Delta: fix NULL pointer dereference
Date: Tue, 1 Feb 2011 21:33:01 +0000 [thread overview]
Message-ID: <20110201213301.GB12101@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201102011840.55512.jkrzyszt@tis.icnet.pl>
On Tue, Feb 01, 2011 at 06:40:55PM +0100, Janusz Krzysztofik wrote:
> It looks like the .card member of the snd_soc_pcm_runtime structure
> pointed to by the snd_soc_dai_link.init() argument is no longer
> initialized before the function being called. As the Amstrad Delta sound
> card driver was making use of it for locating its snd_soc_card
> structure, this resulted in actual or potential NULL pointer
> dereferences.
Seems like it'd be better to fix this in the core - this is a reasonable
thing to want to have set up and the use ams-delta makes of it seems
perfectly sensible. Care to do a patch?
next prev parent reply other threads:[~2011-02-01 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 17:40 [PATCH] ASoC: Amstrad Delta: fix NULL pointer dereference Janusz Krzysztofik
2011-02-01 21:33 ` Mark Brown [this message]
2011-02-02 10:02 ` Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201213301.GB12101@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jkrzyszt@tis.icnet.pl \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.