From: Sergiy Kibrik <sakib@meta.ua>
To: David Lamparter <equinox@diac24.net>
Cc: Steve Glendinning <steve.glendinning@smsc.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb:smsc: preserve MAC address when resetting device
Date: Tue, 1 Feb 2011 22:58:42 +0200 [thread overview]
Message-ID: <201102012258.49375.sakib@meta.ua> (raw)
In-Reply-To: <20110201112425.GA3407894@jupiter.n2.diac24.net>
[-- Attachment #1: Type: Text/Plain, Size: 448 bytes --]
On Tuesday 01 February 2011 13:24:25 David Lamparter wrote:
> You cannot do that. Imagine if I plug in two devices. Only the first one
> will get a MAC properly. Or imagine if i plug a device, unplug it and
> plug it back. It will have an uninitialized mac address.
>
> You need to move the init_mac_address call to happen on device plug-in.
>
>
> -David
Sorry, didn't take into account such case. Will resubmit
-regards,
Sergey
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 316 bytes --]
prev parent reply other threads:[~2011-02-01 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 10:34 [PATCH] usb:smsc: preserve MAC address when resetting device Sergiy Kibrik
2011-02-01 11:24 ` David Lamparter
2011-02-01 20:58 ` Sergiy Kibrik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102012258.49375.sakib@meta.ua \
--to=sakib@meta.ua \
--cc=equinox@diac24.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.