From mboxrd@z Thu Jan 1 00:00:00 1970 From: Francesco Allertsen Subject: Re: Intel i915 freeze on latest git Date: Wed, 2 Feb 2011 12:46:54 +0100 Message-ID: <20110202114653.GA2243@fujiko> References: <20110201112200.GA2349@fujiko> <1bdc18$jeuv05@fmsmga002.fm.intel.com> <20110201122943.GA2011@fujiko> <20110201140754.GA2229@fujiko> <20110201083112.3cfefc3a@jbarnes-desktop> <20110202095656.GA2202@fujiko> <1bdc18$jfb1or@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.emaiti.net (emaiti.net [46.4.199.113]) by gabe.freedesktop.org (Postfix) with ESMTP id 684F39E73F for ; Wed, 2 Feb 2011 03:45:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <1bdc18$jfb1or@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Feb 02, 2011 at 09:59:54AM +0000, Chris Wilson wrote: > Hmm, that was the only change I could spot between the two patches. Care > to disable that function and see what happens? [i.e. put a return before > we write anything to the ring] I've tried with the following patch diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 7769768..2ef0333 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -6505,6 +6505,8 @@ void ironlake_enable_rc6(struct drm_device *dev) struct drm_i915_private *dev_priv = dev->dev_private; int ret; + return; + /* * GPU can automatically power down the render unit if given a page * to save state. So to return at the beginning of the function, and everything works again. Bye Francesco