From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] spi: spidev: Add 32 bit compat ioctl() Date: Wed, 2 Feb 2011 12:15:28 +0100 Message-ID: <201102021215.29002.arnd@arndb.de> References: <1296644235-23933-1-git-send-email-walle@corscience.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: dbrownell@users.sourceforge.net, grant.likely@secretlab.ca, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, akpm@linux-foundation.org To: Bernhard Walle Return-path: In-Reply-To: <1296644235-23933-1-git-send-email-walle@corscience.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-spi.vger.kernel.org On Wednesday 02 February 2011, Bernhard Walle wrote: > Add the compat_ioctl for operations on /dev/spi* so that 32 bit > userspace applications can access SPI. As far as I can see all data > structure are already prepared for that, so no additional conversion has > to be done. > > My use case is MIPS with N32 userspace ABI and toolchain, and that was > also the platform where I tested it successfully (Cavium Octeon). > > Signed-off-by: Bernhard Walle I think you now need to #include as well, to get the definition of compat_ptr(). Otherwise looks good. Arnd