From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: Thomas Renninger <trenn@suse.de>
Cc: linux@dominikbrodowski.net, cpufreq@vger.kernel.org
Subject: Re: [PATCH 3/4] libcpupower: libcpufreq: Provide boost information also for AMD family 12h and 15h
Date: Wed, 2 Feb 2011 20:07:27 +0100 [thread overview]
Message-ID: <20110202190727.GA30936@alberich.amd.com> (raw)
In-Reply-To: <c415675017a84c013931e1ee0797468c1107ed33.1296572755.git.trenn@suse.de>
Thomas,
Arrgh ...
Accidentally I had forwarded you some old bogus patch.
Thus the device ID for family 15h is incorrect.
The patch better should look like below patch.
(It doesn't apply on your current tree, I guess, due to different
directory names)
Sorry for the hassle,
Andreas
From: Andreas Herrmann <andreas.herrmann3@amd.com>
libcpupower: libcpufreq: Provide CPB information for AMD CPU family 12h and 15h
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
lib/amdpci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/amdpci.c b/lib/amdpci.c
index 1463db3..41e4908 100644
--- a/lib/amdpci.c
+++ b/lib/amdpci.c
@@ -48,7 +48,7 @@ static void amd_pci_nb_fini(void)
int amd_pci_get_num_boost_states(int *active, int *states)
{
uint8_t val;
- int dev_ids[2] = {0x1204, 0};
+ int dev_ids[2] = {0x1204, 0x1604, 0x1704, 0};
struct pci_dev *device;
device = amd_pci_nb_init(dev_ids);
@@ -60,7 +60,7 @@ int amd_pci_get_num_boost_states(int *active, int *states)
*active = 1;
else
*active = 0;
- *states = (val >> 2) & 1;
+ *states = (val >> 2) & 7;
}
amd_pci_nb_fini();
--
1.7.4.rc3
next prev parent reply other threads:[~2011-02-02 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 15:11 [PATCH 0/4] Add some AMD boost state info and tiny fixes Thomas Renninger
2011-02-01 15:11 ` [PATCH 1/4] libcpupower/cpufreq-info: Add basic functions to detect AMD CPB information Thomas Renninger
2011-02-01 15:11 ` [PATCH 2/4] Make linking quiet again Thomas Renninger
2011-02-01 15:11 ` [PATCH 3/4] libcpupower: libcpufreq: Provide boost information also for AMD family 12h and 15h Thomas Renninger
2011-02-02 19:07 ` Andreas Herrmann [this message]
2011-02-01 15:11 ` [PATCH 4/4] cpufreq-aperf: mperf might tick faster than expected, esp on Intel Thomas Renninger
2011-02-01 15:25 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202190727.GA30936@alberich.amd.com \
--to=herrmann.der.user@googlemail.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.