From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>
Subject: [patch 8/8] genirq: Make handle_IRQ_event private to the core code
Date: Wed, 02 Feb 2011 21:41:54 -0000 [thread overview]
Message-ID: <20110202212552.531432946@linutronix.de> (raw)
In-Reply-To: 20110202212258.546660886@linutronix.de
[-- Attachment #1: genirq-make-handle_IRQ_event-private-to-genirq.patch --]
[-- Type: text/plain, Size: 5996 bytes --]
No more users outside of kernel/irq. We really want to have flow
handlers in the core code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
Documentation/DocBook/genericirq.tmpl | 10 +++++-----
include/linux/irq.h | 3 ---
kernel/irq/chip.c | 10 +++++-----
kernel/irq/handle.c | 4 ++--
kernel/irq/internals.h | 3 +++
kernel/irq/spurious.c | 2 +-
6 files changed, 16 insertions(+), 16 deletions(-)
Index: linux-2.6-tip/Documentation/DocBook/genericirq.tmpl
===================================================================
--- linux-2.6-tip.orig/Documentation/DocBook/genericirq.tmpl
+++ linux-2.6-tip/Documentation/DocBook/genericirq.tmpl
@@ -285,7 +285,7 @@ noop(struct irq_data *data))
The following control flow is implemented (simplified excerpt):
<programlisting>
desc->chip->irq_mask();
-handle_IRQ_event(desc->action);
+handle_irq_event(desc->action);
desc->chip->irq_unmask();
</programlisting>
</para>
@@ -300,7 +300,7 @@ desc->chip->irq_unmask();
<para>
The following control flow is implemented (simplified excerpt):
<programlisting>
-handle_IRQ_event(desc->action);
+handle_irq_event(desc->action);
desc->chip->irq_eoi();
</programlisting>
</para>
@@ -325,7 +325,7 @@ do {
if (desc->status & masked)
desc->chip->irq_unmask();
desc->status &= ~pending;
- handle_IRQ_event(desc->action);
+ handle_irq_event(desc->action);
} while (status & pending);
desc->status &= ~running;
</programlisting>
@@ -344,7 +344,7 @@ desc->status &= ~running;
<para>
The following control flow is implemented (simplified excerpt):
<programlisting>
-handle_IRQ_event(desc->action);
+handle_irq_event(desc->action);
</programlisting>
</para>
</sect3>
@@ -362,7 +362,7 @@ handle_IRQ_event(desc->action);
<para>
The following control flow is implemented (simplified excerpt):
<programlisting>
-handle_IRQ_event(desc->action);
+handle_irq_event(desc->action);
if (desc->chip->irq_eoi)
desc->chip->irq_eoi();
</programlisting>
Index: linux-2.6-tip/include/linux/irq.h
===================================================================
--- linux-2.6-tip.orig/include/linux/irq.h
+++ linux-2.6-tip/include/linux/irq.h
@@ -236,9 +236,6 @@ static inline void move_masked_irq(int i
extern int no_irq_affinity;
-/* Handle irq action chains: */
-extern irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action);
-
/*
* Built-in IRQ handlers for various IRQ types,
* callable via desc->handle_irq()
Index: linux-2.6-tip/kernel/irq/chip.c
===================================================================
--- linux-2.6-tip.orig/kernel/irq/chip.c
+++ linux-2.6-tip/kernel/irq/chip.c
@@ -492,7 +492,7 @@ handle_simple_irq(unsigned int irq, stru
desc->status |= IRQ_INPROGRESS;
raw_spin_unlock(&desc->lock);
- action_ret = handle_IRQ_event(irq, action);
+ action_ret = handle_irq_event(irq, action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);
@@ -537,7 +537,7 @@ handle_level_irq(unsigned int irq, struc
desc->status |= IRQ_INPROGRESS;
raw_spin_unlock(&desc->lock);
- action_ret = handle_IRQ_event(irq, action);
+ action_ret = handle_irq_event(irq, action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);
@@ -590,7 +590,7 @@ handle_fasteoi_irq(unsigned int irq, str
desc->status &= ~IRQ_PENDING;
raw_spin_unlock(&desc->lock);
- action_ret = handle_IRQ_event(irq, action);
+ action_ret = handle_irq_event(irq, action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);
@@ -669,7 +669,7 @@ handle_edge_irq(unsigned int irq, struct
desc->status &= ~IRQ_PENDING;
raw_spin_unlock(&desc->lock);
- action_ret = handle_IRQ_event(irq, action);
+ action_ret = handle_irq_event(irq, action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);
raw_spin_lock(&desc->lock);
@@ -700,7 +700,7 @@ handle_percpu_irq(unsigned int irq, stru
if (desc->irq_data.chip->irq_ack)
desc->irq_data.chip->irq_ack(&desc->irq_data);
- action_ret = handle_IRQ_event(irq, desc->action);
+ action_ret = handle_irq_event(irq, desc->action);
if (!noirqdebug)
note_interrupt(irq, desc, action_ret);
Index: linux-2.6-tip/kernel/irq/handle.c
===================================================================
--- linux-2.6-tip.orig/kernel/irq/handle.c
+++ linux-2.6-tip/kernel/irq/handle.c
@@ -52,13 +52,13 @@ static void warn_no_thread(unsigned int
}
/**
- * handle_IRQ_event - irq action chain handler
+ * handle_irq_event - irq action chain handler
* @irq: the interrupt number
* @action: the interrupt action chain for this irq
*
* Handles the action chain of an irq event
*/
-irqreturn_t handle_IRQ_event(unsigned int irq, struct irqaction *action)
+irqreturn_t handle_irq_event(unsigned int irq, struct irqaction *action)
{
irqreturn_t ret, retval = IRQ_NONE;
unsigned int status = 0;
Index: linux-2.6-tip/kernel/irq/internals.h
===================================================================
--- linux-2.6-tip.orig/kernel/irq/internals.h
+++ linux-2.6-tip/kernel/irq/internals.h
@@ -40,6 +40,9 @@ static inline void unregister_handler_pr
struct irqaction *action) { }
#endif
+/* Handle irq action chains: */
+extern irqreturn_t handle_irq_event(unsigned int irq, struct irqaction *action);
+
extern int irq_select_affinity_usr(unsigned int irq);
extern void irq_set_thread_affinity(struct irq_desc *desc);
Index: linux-2.6-tip/kernel/irq/spurious.c
===================================================================
--- linux-2.6-tip.orig/kernel/irq/spurious.c
+++ linux-2.6-tip/kernel/irq/spurious.c
@@ -71,7 +71,7 @@ static int try_one_irq(int irq, struct i
*/
work = 1;
raw_spin_unlock(&desc->lock);
- handle_IRQ_event(irq, action);
+ handle_irq_event(irq, action);
raw_spin_lock(&desc->lock);
desc->status &= ~IRQ_PENDING;
}
prev parent reply other threads:[~2011-02-02 21:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 21:41 [patch 0/8] genirq: Further cleanups for .39 Thomas Gleixner
2011-02-02 21:41 ` [patch 1/8] genirq: Remove bogus conditional Thomas Gleixner
2011-02-19 12:22 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2011-02-02 21:41 ` [patch 2/8] genirq: Consolidate startup/shutdown of interrupts Thomas Gleixner
2011-02-19 12:22 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2011-02-02 21:41 ` [patch 3/8] genirq: Do not fiddle with IRQ_MASKED in handle_edge_irq() Thomas Gleixner
2011-02-19 12:24 ` [tip:irq/core] " tip-bot for Thomas Gleixner
2011-02-02 21:41 ` [patch 4/8] genirq: Introduce IRQ_EDGE_EOI flag Thomas Gleixner
2011-02-02 21:41 ` [patch 5/8] powerpc: cell: Use handle_edge_irq Thomas Gleixner
2011-02-02 21:41 ` [patch 6/8] arm: ns9xxx: Remove private irq flow handler Thomas Gleixner
2011-02-02 21:41 ` Thomas Gleixner
2011-02-03 7:56 ` Uwe Kleine-König
2011-02-03 7:56 ` Uwe Kleine-König
2011-03-28 17:13 ` [tip:irq/urgent] arm: Ns9xxx: " tip-bot for Thomas Gleixner
2011-02-02 21:41 ` [patch 7/8] m68knommu: 5772: Replace " Thomas Gleixner
2011-02-02 22:27 ` Greg Ungerer
2011-02-02 22:37 ` Thomas Gleixner
2011-02-02 22:41 ` Greg Ungerer
2011-02-02 21:41 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202212552.531432946@linutronix.de \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.