From: Simon Horman <horms@verge.net.au>
To: Patrick McHardy <kaber@trash.net>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, lvs-devel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Hans Schillstrom <hans@schillstrom.com>
Subject: Re: [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups
Date: Thu, 3 Feb 2011 06:39:07 +0900 [thread overview]
Message-ID: <20110202213907.GI2248@verge.net.au> (raw)
In-Reply-To: <4D4840BC.4050303@trash.net>
On Tue, Feb 01, 2011 at 06:19:56PM +0100, Patrick McHardy wrote:
> Am 01.02.2011 18:05, schrieb Randy Dunlap:
> > On 02/01/11 02:04, Simon Horman wrote:
> >> On Tue, Feb 01, 2011 at 03:06:37PM +1100, Simon Horman wrote:
> >>> On Mon, Jan 31, 2011 at 04:50:09PM -0800, Randy Dunlap wrote:
> >>>> On Tue, 1 Feb 2011 11:14:11 +1100 Simon Horman wrote:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> This short patch series addresses two linux-next build problems
> >>>>> raised by Randy Dunlap:
> >>>>>
> >>>>> * net/netfilter/ipvs/ip_vs_core.c:1891: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'unsigned int'
> >>>>> * ERROR: "unregister_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko]
> >>>>> ERROR: "register_net_sysctl_table" [net/netfilter/ipvs/ip_vs.ko] undefined!
> >>>>>
> >>>>> The remainder of the changset is cleanups that I noticed along the way.
> >>>>
> >>>> These 4 patches build successfully for me.
> >>>> However, I do see these warnings (sorry I missed them earlier):
> >>>>
> >>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup()
> >>>> WARNING: net/netfilter/ipvs/ip_vs.o(.init.text+0x161): Section mismatch in reference from the function init_module() to the function .exit.text:ip_vs_sync_cleanup()
> >>>
> >>> Thanks, I'll look into that. I will be travelling for a good portion of the
> >>> next day and a bit so I apologise in advance if that delays my next patch.
> >>
> >> Hi,
> >>
> >> I the following patch seems to be the right fix for this to me.
> >> I will send an amended pull request.
> >>
> >> IPVS: Remove ip_vs_sync_cleanup from section __exit
> >>
> >> ip_vs_sync_cleanup() may be called from ip_vs_init() on error
> >> and thus needs to be accesible from section __init
> >>
> >> Reporte-by: Randy Dunlap <randy.dunlap@oracle.com>
> > Reported-by:
> >
> >> Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> Thanks, since Simon is travelling, I'll apply the patches now
> with your and Hans's Acks and will push them to Dave later.
Thanks, I've finished travelling now :-)
next prev parent reply other threads:[~2011-02-02 21:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 0:14 [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups Simon Horman
2011-02-01 0:14 ` [PATCH 1/4] IPVS: use z modifier for sizeof() argument Simon Horman
2011-02-01 0:14 ` [PATCH 2/4] IPVS: remove duplicate initialisation or rs_table Simon Horman
2011-02-01 0:14 ` [PATCH 3/4] IPVS: Remove unused variables Simon Horman
2011-02-01 0:14 ` [PATCH 4/4] IPVS: Allow compilation with CONFIG_SYSCTL disabled Simon Horman
2011-02-01 0:50 ` [GIT PULL nf-next-2.6] IPVS build fixes and clean-ups Randy Dunlap
2011-02-01 4:06 ` Simon Horman
2011-02-01 10:04 ` Simon Horman
2011-02-01 17:05 ` Randy Dunlap
2011-02-01 17:19 ` Patrick McHardy
2011-02-02 21:39 ` Simon Horman [this message]
2011-02-02 23:02 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202213907.GI2248@verge.net.au \
--to=horms@verge.net.au \
--cc=hans@schillstrom.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.