From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Provide in/out{b,w,l}
Date: Wed, 02 Feb 2011 23:42:29 +0000 [thread overview]
Message-ID: <20110202234229.GB11610@linux-sh.org> (raw)
In-Reply-To: <1296630315-21264-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Wed, Feb 02, 2011 at 04:05:15PM +0900, Nobuhiro Iwamatsu wrote:
> By commit 37b7a97884ba64bf7d403351ac2a9476ab4f1bba,
> delete machvec IO routines.
> Because the definition of in/out_{b,w,l} was deleted,
> driver needing these cannot build.
> This defines it again.
>
Wrong. Please actually study the change and try to figure out what it is
doing before re-introducing stuff it intentionally removed.
The only time we have PIO is when PCI is available, anything else is just
broken wrapping in to MMIO due to drivers using legacy PIO accessors.
These are now few enough that it's trivial to simply fix up the drivers
accordingly.
If IOPORT support is enabled (by way of CONFIG_PCI) then all of the PIO
routines likewise become available -- these are constructed by the
BUILDIO_IOPORT macro. The PIO offsets in question are then relative to
the PCI channel's I/O base.
It took us years to get rid of all of the crap SuperIO fake PIO nonsense,
any attempt to re-add bogus PIO routines in an IOMEM only configuration
are fundamentally broken.
next prev parent reply other threads:[~2011-02-02 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 7:05 [PATCH] sh: Provide in/out{b,w,l} Nobuhiro Iwamatsu
2011-02-02 23:42 ` Paul Mundt [this message]
2011-02-09 4:05 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110202234229.GB11610@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.