From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/activate/activate.c lib/a ...
Date: 3 Feb 2011 01:24:48 -0000 [thread overview]
Message-ID: <20110203012448.15847.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: zkabelac at sourceware.org 2011-02-03 01:24:47
Modified files:
. : WHATS_NEW
lib/activate : activate.c fs.c
liblvm : lvm_lv.c
tools : lvconvert.c lvscan.c
Log message:
Do not check for open_count when not needed.
Disable open_count checking in lv_info it it's not used.
Fix previous commit (comment out unsable code for now).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1898&r2=1.1899
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.187&r2=1.188
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/fs.c.diff?cvsroot=lvm2&r1=1.57&r2=1.58
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/liblvm/lvm_lv.c.diff?cvsroot=lvm2&r1=1.34&r2=1.35
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvconvert.c.diff?cvsroot=lvm2&r1=1.156&r2=1.157
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvscan.c.diff?cvsroot=lvm2&r1=1.44&r2=1.45
--- LVM2/WHATS_NEW 2011/02/02 23:39:39 1.1898
+++ LVM2/WHATS_NEW 2011/02/03 01:24:46 1.1899
@@ -1,5 +1,7 @@
Version 2.02.83 -
===================================
+ Remove unneeded checks for open_count in lv_info().
+ Synchronize with udev before checking open_count in lv_info().
Allow CLVMD_CMD_SYNC_NAMES to be propagated around the cluster if requested.
Add "dmsetup ls --tree" output to lvmdump.
Fix udev synchronization with no-locking --sysinit (2.02.80).
--- LVM2/lib/activate/activate.c 2011/02/03 01:16:35 1.187
+++ LVM2/lib/activate/activate.c 2011/02/03 01:24:46 1.188
@@ -469,7 +469,7 @@
if (with_open_count) {
if (locking_is_clustered())
sync_local_dev_names(cmd); /* Wait to have udev in sync */
- else if (fs_has_non_delete_ops())
+ else //if (fs_has_non_delete_ops())
fs_unlock(); /* For non clustered - wait if there are non-delete ops */
}
@@ -1219,7 +1219,7 @@
r = _lv_deactivate(lv);
memlock_dec(cmd);
- if (!lv_info(cmd, lv, 0, &info, 1, 0) || info.exists)
+ if (!lv_info(cmd, lv, 0, &info, 0, 0) || info.exists)
r = 0;
out:
if (lv) {
--- LVM2/lib/activate/fs.c 2011/02/03 01:16:35 1.57
+++ LVM2/lib/activate/fs.c 2011/02/03 01:24:46 1.58
@@ -423,7 +423,9 @@
_fs_cookie = cookie;
}
+#if 0
int fs_has_non_delete_ops(void)
{
return _other_fs_ops(FS_DEL);
}
+#endif
--- LVM2/liblvm/lvm_lv.c 2010/12/14 23:20:58 1.34
+++ LVM2/liblvm/lvm_lv.c 2011/02/03 01:24:46 1.35
@@ -62,7 +62,7 @@
uint64_t lvm_lv_is_active(const lv_t lv)
{
struct lvinfo info;
- if (lv_info(lv->vg->cmd, lv, 0, &info, 1, 0) &&
+ if (lv_info(lv->vg->cmd, lv, 0, &info, 0, 0) &&
info.exists && info.live_table)
return 1;
return 0;
@@ -71,7 +71,7 @@
uint64_t lvm_lv_is_suspended(const lv_t lv)
{
struct lvinfo info;
- if (lv_info(lv->vg->cmd, lv, 0, &info, 1, 0) &&
+ if (lv_info(lv->vg->cmd, lv, 0, &info, 0, 0) &&
info.exists && info.suspended)
return 1;
return 0;
--- LVM2/tools/lvconvert.c 2011/01/19 19:24:07 1.156
+++ LVM2/tools/lvconvert.c 2011/02/03 01:24:47 1.157
@@ -1637,7 +1637,7 @@
{
struct lvinfo info;
- if (!lv_info(cmd, lv, 0, &info, 1, 0) || !info.exists) {
+ if (!lv_info(cmd, lv, 0, &info, 0, 0) || !info.exists) {
log_print("Conversion starts after activation.");
return ECMD_PROCESSED;
}
--- LVM2/tools/lvscan.c 2010/12/22 12:06:54 1.44
+++ LVM2/tools/lvscan.c 2011/02/03 01:24:47 1.45
@@ -28,7 +28,7 @@
if (!arg_count(cmd, all_ARG) && !lv_is_visible(lv))
return ECMD_PROCESSED;
- inkernel = lv_info(cmd, lv, 0, &info, 1, 0) && info.exists;
+ inkernel = lv_info(cmd, lv, 0, &info, 0, 0) && info.exists;
if (lv_is_origin(lv)) {
dm_list_iterate_items_gen(snap_seg, &lv->snapshot_segs,
origin_list) {
next reply other threads:[~2011-02-03 1:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 1:24 zkabelac [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-23 9:58 LVM2 ./WHATS_NEW lib/activate/activate.c lib/a zkabelac
2012-02-23 22:42 zkabelac
2012-01-25 13:10 zkabelac
2012-01-25 8:48 zkabelac
2011-11-18 19:31 zkabelac
2011-10-06 14:55 jbrassow
2011-10-03 18:37 zkabelac
2011-09-22 17:33 prajnoha
2011-06-30 18:25 agk
2011-06-22 21:31 jbrassow
2011-06-17 14:22 zkabelac
2011-06-17 14:14 zkabelac
2011-07-04 14:55 ` Alasdair G Kergon
2011-02-04 19:14 zkabelac
2010-08-17 1:16 agk
2010-02-24 20:01 mbroz
2010-02-24 20:00 mbroz
2009-10-01 0:35 agk
2009-06-01 12:43 mbroz
2009-05-20 11:09 mbroz
2009-05-20 9:52 mbroz
2009-02-28 0:54 agk
2008-12-19 14:22 prajnoha
2008-12-19 14:58 ` Alasdair G Kergon
2008-04-07 10:23 mbroz
2008-01-30 14:00 agk
2007-11-12 20:51 agk
2007-07-02 11:17 wysochanski
2007-03-08 21:08 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203012448.15847.qmail@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.