From: Yong Zhang <yong.zhang0@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nick Bowler <nbowler@elliptictech.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Regression: WARNINGS and lockdep spews in 2.6.38-rc3+ (bisected).
Date: Thu, 3 Feb 2011 19:42:19 +0800 [thread overview]
Message-ID: <20110203114218.GA1809@zhy> (raw)
In-Reply-To: <1296729184.26581.361.camel@laptop>
On Thu, Feb 03, 2011 at 11:33:04AM +0100, Peter Zijlstra wrote:
>
> How about we revert your patch and go back to not allowing
> del_timer_sync() from any interrupt context,
The fact is there is someone want to use del_timer_sync()
in softirq context.
My patch is inspired by this http://lkml.org/lkml/2010/8/16/291
though in the end that issue is resolved by not using
del_timer_sync() in softirq.
> we can fix __dst_free by
> removing the need for cancel_delayed_work().
>
> Are there any other del_timer_sync() callers from softirq?
I'm not sure about this.
IMHO, we don't need to make more restriction if we don't
have to.
Thanks,
Yong
next prev parent reply other threads:[~2011-02-03 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 3:19 Regression: WARNINGS and lockdep spews in 2.6.38-rc3+ (bisected) Nick Bowler
2011-02-03 9:12 ` Yong Zhang
2011-02-03 9:30 ` Peter Zijlstra
2011-02-03 10:17 ` Yong Zhang
2011-02-03 10:33 ` Peter Zijlstra
2011-02-03 11:42 ` Yong Zhang [this message]
2011-02-08 16:55 ` Peter Zijlstra
2011-02-08 17:39 ` [PATCH] lockdep/timers: Explain in detail the locking problems del_timer_sync() may cause Steven Rostedt
2011-02-16 13:51 ` [tip:core/locking] " tip-bot for Steven Rostedt
2011-02-03 11:50 ` [PATCH 1/2] softirq: introduce loacal_bh_enable_force_wake() Yong Zhang
2011-02-03 11:53 ` [PATCH 2/2] timer: use local_bh_enable_force_wake() in del_timer_sync() Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203114218.GA1809@zhy \
--to=yong.zhang0@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.