From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p13M0INk219564 for ; Thu, 3 Feb 2011 16:00:18 -0600 Received: from mail-ey0-f181.google.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A4E83162EE08 for ; Thu, 3 Feb 2011 14:02:43 -0800 (PST) Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com [209.85.215.181]) by cuda.sgi.com with ESMTP id oyL03qhO6afvHtEu for ; Thu, 03 Feb 2011 14:02:43 -0800 (PST) Received: by eyh6 with SMTP id 6so1066978eyh.26 for ; Thu, 03 Feb 2011 14:02:42 -0800 (PST) From: Arkadiusz Miskiewicz Subject: Re: [GIT PULL] XFS update for 2.6.38-rc3 Date: Thu, 3 Feb 2011 23:02:31 +0100 References: <201101311642.p0VGgXTS018851@stout.americas.sgi.com> <4D482E21.5040803@teksavvy.com> <20110203000757.GT11040@dastard> In-Reply-To: <20110203000757.GT11040@dastard> MIME-Version: 1.0 Message-Id: <201102032302.31780.a.miskiewicz@gmail.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com, linux-kernel@vger.kernel.org Cc: Mark Lord , stable@kernel.org, Alex Elder T24gVGh1cnNkYXkgMDMgb2YgRmVicnVhcnkgMjAxMSwgRGF2ZSBDaGlubmVyIHdyb3RlOgo+IE9u IFR1ZSwgRmViIDAxLCAyMDExIGF0IDExOjAwOjMzQU0gLTA1MDAsIE1hcmsgTG9yZCB3cm90ZToK PiA+IE9uIDExLTAxLTMxIDExOjQyIEFNLCBBbGV4IEVsZGVyIHdyb3RlOgo+ID4gPiBMaW51cywg cGxlYXNlIGFjY2VwdCB0aGUgZm9sbG93aW5nIHVwZGF0ZXMgZm9yIFhGUywgZm9yIDIuNi4zOC1y YzMKPiA+ID4gKGlmIGl0J3Mgbm90IHRvbyBsYXRlKSBvciAyLjYuMzgtcmM0Lgo+ID4gPiAKPiA+ ID4gVGhleSBhcmUgYWxsIGZpeGVzIGZvciBidWdzIHRoYXQgaGF2ZSBzb21lIHByZXR0eSB1bmRl c2lyYWJsZQo+ID4gPiBjb25zZXF1ZW5jZXMuIAoKWy4uLl0KCj4gPiBBcmUgdGhlc2UgYnVncyBh bGwgbmV3IGluIDIuNi4zOCwgb3Igc2hvdWxkIHNvbWUgb2YgdGhlc2UgZml4ZXMKPiA+IGFsc28g Z28gb3V0IHRvIC1zdGFibGUgZm9yIGVhcmxpZXIgcmV2aXNpb25zPwo+ID4gPiAgICAgICB4ZnM6 IGZpeCBkcXVvdCBzaGFrZXIgZGVhZGxvY2sKPiAKPiBUaGF0J3MgYSByZWdyZXNzaW9uLCBzbyBt YXliZS4KCkRlZmluaXRlbHksIHhmc19mc3IgY2FuIGhpdCB0aGlzIGV2ZW4gZmV3IHRpbWVzIGEg ZGF5IChoYXBwZW5lZCBhbHJlYWR5KS4KClN0YWJsZSB0ZWFtLCBwbGVhc2UgaW5jbHVkZSB0aGlz IG9uZSBmb3IgMi42LjM3LjE6Cgpjb21taXQgMGZiY2E0ZDFjMzkzMmMyN2M0Nzk0YmY1YzJiNWZj OTYxY2Y1YTU0ZgpBdXRob3I6IERhdmUgQ2hpbm5lciA8ZGNoaW5uZXJAcmVkaGF0LmNvbT4KRGF0 ZTogICBGcmkgSmFuIDI4IDExOjIwOjQ2IDIwMTEgKzExMDAKCiAgICB4ZnM6IGZpeCBkcXVvdCBz aGFrZXIgZGVhZGxvY2sKCiAgICBDb21taXQgMzY4ZTEzNiAoInhmczogcmVtb3ZlIGR1cGxpY2F0 ZSBjb2RlIGZyb20gZHF1b3QgcmVjbGFpbSIpIGZhaWxzCiAgICB0byB1bmxvY2sgdGhlIGRxdW90 IGZyZWVsaXN0IHdoZW4gdGhlIG51bWJlciBvZiBsb29wIHJlc3RhcnRzIGlzCiAgICBleGNlZWRl ZCBpbiB4ZnNfcW1fZHFyZWNsYWltX29uZSgpLiBUaGlzIGNhdXNlcyBoYW5ncyBpbiBtZW1vcnkK ICAgIHJlY2xhaW0uCgogICAgUmV3b3JrIHRoZSBsb29wIGNvbnRyb2wgbG9naWMgaW50byBhbiB1 bndpbmQgc3RhY2sgdGhhdCBhbGwgdGhlCiAgICBkaWZmZXJlbnQgY2FzZXMganVtcCBpbnRvLiBU aGlzIG1lYW5zIHRoZXJlIGlzIG9ubHkgb25lIHNldCBvZiBjb2RlCiAgICB0aGF0IHByb2Nlc3Nl cyB0aGUgbG9vcCBleGl0IGNyaXRlcmlhLCBhbmQgc2ltcGxpZmllcyB0aGUgdW5sb2NraW5nCiAg ICBvZiBhbGwgdGhlIGl0ZW1zIGZyb20gZGlmZmVyZW50IHBvaW50cyBpbiB0aGUgbG9vcC4gSXQg YWxzbyBmaXhlcyBhCiAgICBkb3VibGUgaW5jcmVtZW50IG9mIHRoZSByZXN0YXJ0IGNvdW50ZXIg ZnJvbSB0aGUgcWlfZHFsaXN0X2xvY2sKICAgIGNhc2UuCgogICAgUmVwb3J0ZWQtYnk6IE1hbGNv bG0gU2NvdHQgPGxrbWxAbWFsYy5vcmcudWs+CiAgICBTaWduZWQtb2ZmLWJ5OiBEYXZlIENoaW5u ZXIgPGRjaGlubmVyQHJlZGhhdC5jb20+CiAgICBSZXZpZXdlZC1ieTogQWxleCBFbGRlciA8YWVs ZGVyQHNnaS5jb20+CgoKPiBDaGVlcnMsCj4gCj4gRGF2ZS4KCgotLSAKQXJrYWRpdXN6IE1pxZtr aWV3aWN6ICAgICAgICBQTEQvTGludXggVGVhbQphcmVrbSAvIG1hdmVuLnBsICAgICAgICAgICAg aHR0cDovL2Z0cC5wbGQtbGludXgub3JnLwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KeGZzIG1haWxpbmcgbGlzdAp4ZnNAb3NzLnNnaS5jb20KaHR0cDov L29zcy5zZ2kuY29tL21haWxtYW4vbGlzdGluZm8veGZzCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754030Ab1BCWCq (ORCPT ); Thu, 3 Feb 2011 17:02:46 -0500 Received: from mail-ew0-f46.google.com ([209.85.215.46]:63134 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753611Ab1BCWCn convert rfc822-to-8bit (ORCPT ); Thu, 3 Feb 2011 17:02:43 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=I9KjeCWqk3tfaVtC+/iFvyaPFE1VGUIJ/msdpy6+oy5yFNHr9QsXSr7AJlBmBc0ssM bmsR3Ct7ArXPEOqcUx5g5S8spwaYpzIPFp3ld7oYLLlEDzpeKjI5ZsHfT/MrrAJV6Ked M2fnsU59yRn18uTZDIsqEQFp964cfFeqmypVI= From: Arkadiusz Miskiewicz To: xfs@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] XFS update for 2.6.38-rc3 Date: Thu, 3 Feb 2011 23:02:31 +0100 User-Agent: KMail/1.13.6 (Linux/2.6.37; KDE/4.6.0; x86_64; ; ) Cc: Dave Chinner , Mark Lord , Alex Elder , stable@kernel.org References: <201101311642.p0VGgXTS018851@stout.americas.sgi.com> <4D482E21.5040803@teksavvy.com> <20110203000757.GT11040@dastard> In-Reply-To: <20110203000757.GT11040@dastard> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Message-Id: <201102032302.31780.a.miskiewicz@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 03 of February 2011, Dave Chinner wrote: > On Tue, Feb 01, 2011 at 11:00:33AM -0500, Mark Lord wrote: > > On 11-01-31 11:42 AM, Alex Elder wrote: > > > Linus, please accept the following updates for XFS, for 2.6.38-rc3 > > > (if it's not too late) or 2.6.38-rc4. > > > > > > They are all fixes for bugs that have some pretty undesirable > > > consequences. [...] > > Are these bugs all new in 2.6.38, or should some of these fixes > > also go out to -stable for earlier revisions? > > > xfs: fix dquot shaker deadlock > > That's a regression, so maybe. Definitely, xfs_fsr can hit this even few times a day (happened already). Stable team, please include this one for 2.6.37.1: commit 0fbca4d1c3932c27c4794bf5c2b5fc961cf5a54f Author: Dave Chinner Date: Fri Jan 28 11:20:46 2011 +1100 xfs: fix dquot shaker deadlock Commit 368e136 ("xfs: remove duplicate code from dquot reclaim") fails to unlock the dquot freelist when the number of loop restarts is exceeded in xfs_qm_dqreclaim_one(). This causes hangs in memory reclaim. Rework the loop control logic into an unwind stack that all the different cases jump into. This means there is only one set of code that processes the loop exit criteria, and simplifies the unlocking of all the items from different points in the loop. It also fixes a double increment of the restart counter from the qi_dqlist_lock case. Reported-by: Malcolm Scott Signed-off-by: Dave Chinner Reviewed-by: Alex Elder > Cheers, > > Dave. -- Arkadiusz Miśkiewicz PLD/Linux Team arekm / maven.pl http://ftp.pld-linux.org/