All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: jackdachef@gmail.com, linux-kernel@vger.kernel.org,
	ruediger.herbst@googlemail.com, geert@linux-m68k.org
Subject: Re: Sun GEM PPC32 Bug?
Date: Fri, 04 Feb 2011 14:55:08 -0800 (PST)	[thread overview]
Message-ID: <20110204.145508.59670453.davem@davemloft.net> (raw)
In-Reply-To: <1296852667.2349.804.camel@pasglop>

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Sat, 05 Feb 2011 07:51:07 +1100

> The FIFO overflow could be a driver bug or a HW issue, there are some
> known issues with the small FIFOs in that chip, but it's also possible
> that we don't configure them quite right. Anybody wants to dig in and
> see what's going on there ? May want to look at the Darwin sungem driver
> for reference on how it configures them... However, it should generally
> recover when that happens. If not, then we have a bug there.

I think we're simply not resetting enough when the RX FIFO overflow
happens.

Just for fun I checked the OpenBSD GEM driver to see what they do.
When an overflow occurs, they bump the statistic, record the current
read and write fifo pointer registers, and schedule a watchdog timer
for 400ms into the future.

If the watchdog timer sees that the RX FIFO overflow bit is still set
in the RX status register, and the RX FIFO read and write pointers
have not changed, it resets the entire chip.

We unconditionally reset the RX MAC when an overflow occurs, that may
simply not be enough to unwedge this thing.

  reply	other threads:[~2011-02-04 22:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04 16:55 Sun GEM PPC32 Bug? Matt
2011-02-04 20:51 ` Benjamin Herrenschmidt
2011-02-04 22:55   ` David Miller [this message]
2011-02-05 18:35     ` R. Herbst
2011-02-05 23:39       ` Benjamin Herrenschmidt
2011-02-05 23:45         ` Benjamin Herrenschmidt
2011-02-06  0:20         ` Matt
2011-02-05 20:32     ` Matt
2011-02-05 23:20       ` Benjamin Herrenschmidt
2011-02-06 14:22       ` R. Herbst
  -- strict thread matches above, loose matches on Subject: below --
2011-02-06 15:01 R. Herbst
2011-02-07  5:34 ` Benjamin Herrenschmidt
2011-02-08 18:28   ` R. Herbst
2011-02-08 19:58   ` Andreas Schwab
2011-02-09  0:18     ` Benjamin Herrenschmidt
2011-02-09 17:37       ` Andreas Schwab
2011-02-03 19:47 R. Herbst
2011-02-04  8:02 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110204.145508.59670453.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=benh@kernel.crashing.org \
    --cc=geert@linux-m68k.org \
    --cc=jackdachef@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ruediger.herbst@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.