All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Koerber, Philip (GE Intelligent Platforms)" <Philip.Koerber@ge.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo
Date: Fri, 4 Feb 2011 09:11:56 -0800	[thread overview]
Message-ID: <20110204091156.1b8e76fb@jbarnes-desktop> (raw)
In-Reply-To: <BBC019D537C16342B2754DEB36395C0C013AB5EA@BUDMLVEM06.e2k.ad.ge.com>

On Fri, 4 Feb 2011 15:55:30 +0100
"Koerber, Philip (GE Intelligent Platforms)" <Philip.Koerber@ge.com>
wrote:

> Dear Kernel Maintainers,
> 
> I have observed, that on our SBC's the GPU turbo mode doesn't work. This happens only to those with embedded Arrandale (1288 FCBGA package) standard voltage (35W) CPU's. These CPU's do not have there an letter whereas the Mobile CPU has an M. So there seems to be a need to update the intel_ips.c in order to recognize the CPU's with  brand strings 'Intel(R) Core(TM) i7 CPU         610  @ 2.53GHz' and  'Intel(R) Core(TM) i5 CPU         520  @ 2.40GHz'. I have prepared therefor following patch:
> 
> 
> diff -urN linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c linux/drivers/platform/x86/intel_ips.c
> --- linux-2.6.38-rc3/drivers/platform/x86/intel_ips.c	2011-02-01 04:05:49.000000000 +0100
> +++ linux/drivers/platform/x86/intel_ips.c	2011-02-04 15:25:40.205627688 +0100
> @@ -1399,6 +1399,10 @@
>  		limits = &ips_lv_limits;
>  	else if (strstr(boot_cpu_data.x86_model_id, "CPU       U"))
>  		limits = &ips_ulv_limits;
> +	else if (strstr(boot_cpu_data.x86_model_id, "CPU         610"))
> +		limits = &ips_sv_limits;
> +	else if (strstr(boot_cpu_data.x86_model_id, "CPU         520"))
> +		limits = &ips_sv_limits;
>  	else {
>  		dev_info(&ips->dev->dev, "No CPUID match found.\n");
>  		goto out;

Yep, that's fine with me, thanks for the patch!

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2011-02-04 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-04 14:55 [PATCH] embedded 1288 fcbga arrandale cpu not detected in ips module - no gpu turbo Koerber, Philip (GE Intelligent Platforms)
2011-02-04 17:11 ` Jesse Barnes [this message]
2011-02-07 19:13   ` Matthew Garrett
2011-02-07 19:16     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110204091156.1b8e76fb@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=Philip.Koerber@ge.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.