From: "G, Manjunath Kondaiah" <manjugk@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-omap@vger.kernel.org, Jarkko Nikula <jhnikula@gmail.com>
Subject: Re: [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h
Date: Fri, 4 Feb 2011 19:27:14 +0530 [thread overview]
Message-ID: <20110204135714.GD2070@m-desktop> (raw)
In-Reply-To: <1296810909-24737-1-git-send-email-kishon@ti.com>
On Fri, Feb 04, 2011 at 02:45:09PM +0530, Kishon Vijay Abraham I wrote:
> Some macros defined in mcbsp.h related to audio, which are never being used
> is removed.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Reviewed-by: Charulatha V <charu@ti.com>
> Cc: Jarkko Nikula <jhnikula@gmail.com>
> ---
> arch/arm/plat-omap/include/plat/mcbsp.h | 14 --------------
> 1 files changed, 0 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/mcbsp.h b/arch/arm/plat-omap/include/plat/mcbsp.h
> index b87d83c..6ecf105 100644
> --- a/arch/arm/plat-omap/include/plat/mcbsp.h
> +++ b/arch/arm/plat-omap/include/plat/mcbsp.h
> @@ -106,13 +106,6 @@ static struct platform_device omap_mcbsp##port_nr = { \
> #define OMAP_MCBSP_REG_XCCR 0x00
> #define OMAP_MCBSP_REG_RCCR 0x00
>
> -#define AUDIO_MCBSP_DATAWRITE (OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DXR1)
> -#define AUDIO_MCBSP_DATAREAD (OMAP1510_MCBSP1_BASE + OMAP_MCBSP_REG_DRR1)
> -
> -#define AUDIO_MCBSP OMAP_MCBSP1
> -#define AUDIO_DMA_TX OMAP_DMA_MCBSP1_TX
> -#define AUDIO_DMA_RX OMAP_DMA_MCBSP1_RX
Thanks. I have patch in my git repo to cleanup all unwanted dma macros.
I will remove mcbsp dma related declarations in my patch.
Acked-by: G, Manjunath Kondaiah <manjugk@ti.com>
-Manjunath
> -
> #else
>
> #define OMAP_MCBSP_REG_DRR2 0x00
> @@ -168,13 +161,6 @@ static struct platform_device omap_mcbsp##port_nr = { \
> #define OMAP_ST_REG_SFIRCR 0x28
> #define OMAP_ST_REG_SSELCR 0x2C
>
> -#define AUDIO_MCBSP_DATAWRITE (OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DXR1)
> -#define AUDIO_MCBSP_DATAREAD (OMAP24XX_MCBSP2_BASE + OMAP_MCBSP_REG_DRR1)
> -
> -#define AUDIO_MCBSP OMAP_MCBSP2
> -#define AUDIO_DMA_TX OMAP24XX_DMA_MCBSP2_TX
> -#define AUDIO_DMA_RX OMAP24XX_DMA_MCBSP2_RX
> -
> #endif
>
> /************************** McBSP SPCR1 bit definitions ***********************/
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-04 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 9:15 [PATCH] OMAP: McBSP: Remove unused audio macros in mcbsp.h Kishon Vijay Abraham I
2011-02-04 9:46 ` Jarkko Nikula
2011-02-04 13:45 ` Peter Ujfalusi
2011-02-04 13:57 ` G, Manjunath Kondaiah [this message]
2011-02-14 22:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204135714.GD2070@m-desktop \
--to=manjugk@ti.com \
--cc=jhnikula@gmail.com \
--cc=kishon@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.