From: Jan Kara <jack@suse.cz>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Joel Becker <jlbec@evilplan.org>, Ted Ts'o <tytso@mit.edu>,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully.
Date: Fri, 4 Feb 2011 16:53:58 +0100 [thread overview]
Message-ID: <20110204155358.GF4104@quack.suse.cz> (raw)
In-Reply-To: <AANLkTi=x_RufCNMGaM1DBbYKPKdO-JoQP5YCdDz6dfAc@mail.gmail.com>
On Sat 29-01-11 21:40:03, Manish Katiyar wrote:
Hi Manish,
> Have we reached on any conclusion yet on the function name which I can
> use to send my updated patch ? My preference from the above list is to
> use ext4_journal_start_nofs() as that seems the closest match, but I
> would like hear the conclusion from experts.
How about "ext4_journal_start_tryhard()"? I don't like "nofs" because
the fact whether we use GFP_NOFS is separate from the fact whether we are
able to handle memory allocation failure.
In fact, your patch set should keep calling kzalloc() with GFP_NOFS in all
cases to avoid new recursions into the filesystem (which could cause
deadlocks - changing that would need a separate audit if we care enough).
Just the retrying logic should be influenced by your work.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-02-04 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 3:32 [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully Manish Katiyar
2011-01-23 5:40 ` Ted Ts'o
2011-01-23 5:53 ` Manish Katiyar
2011-01-23 6:29 ` Joel Becker
2011-01-24 13:31 ` Jan Kara
2011-01-24 17:20 ` Joel Becker
2011-01-25 11:40 ` Jan Kara
2011-01-25 0:06 ` Andreas Dilger
2011-01-25 11:46 ` Jan Kara
2011-01-30 5:40 ` Manish Katiyar
2011-02-04 15:53 ` Jan Kara [this message]
2011-02-04 22:44 ` Manish Katiyar
2011-04-25 0:06 ` Manish Katiyar
2011-01-25 6:47 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204155358.GF4104@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.