From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57687 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PlRez-0000F5-6t
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 14:49:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PlRex-0000aG-Mm
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 14:49:36 -0500
Received: from hall.aurel32.net ([88.191.126.93]:37975)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1PlRex-0000a6-FB
	for qemu-devel@nongnu.org; Fri, 04 Feb 2011 14:49:35 -0500
Date: Fri, 4 Feb 2011 20:49:40 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-arm: Fix Neon vsra instructions.
Message-ID: <20110204194940.GC10125@volta.aurel32.net>
References: <4D3F05D0.9070906@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4D3F05D0.9070906@st.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christophe Lyon <christophe.lyon@st.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Tue, Jan 25, 2011 at 06:18:08PM +0100, Christophe Lyon wrote:
> This patch fixes the errors reported by my tests in VSRA.
> 
> Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
> ---
>  target-arm/translate.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Thanks applied.

> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 7cb48c0..4cf2ecd 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -4697,7 +4697,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
>                          }
>                          if (op == 1 || op == 3) {
>                              /* Accumulate.  */
> -                            neon_load_reg64(cpu_V0, rd + pass);
> +                            neon_load_reg64(cpu_V1, rd + pass);
>                              tcg_gen_add_i64(cpu_V0, cpu_V0, cpu_V1);
>                          } else if (op == 4 || (op == 5 && u)) {
>                              /* Insert */
> @@ -4761,7 +4761,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
>                          if (op == 1 || op == 3) {
>                              /* Accumulate.  */
>                              tmp2 = neon_load_reg(rd, pass);
> -                            gen_neon_add(size, tmp2, tmp);
> +                            gen_neon_add(size, tmp, tmp2);
>                              dead_tmp(tmp2);
>                          } else if (op == 4 || (op == 5 && u)) {
>                              /* Insert */
> -- 
> 1.7.2.3
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net