Re: World writeable MUX

[Tony Lindgren <tony@atomide.com>]

* Felipe Balbi <balbi@ti.com> [110204 04:42]:
> Hi Tony,
> 
> I saw a few patches floating around regarding world writeable sysfs
> files and decided to grep around arch/arm/*omap* to try and see if we
> were safe. Turns out anyone can change MUX entries via the debugfs
> interface:
> 
> static void __init omap_mux_dbg_create_entry(
> 				struct omap_mux_partition *partition,
> 				struct dentry *mux_dbg_dir)
> {
> 	struct omap_mux_entry *e;
> 
> 	list_for_each_entry(e, &partition->muxmodes, node) {
> 		struct omap_mux *m = &e->mux;
> 
> 		(void)debugfs_create_file(m->muxnames[0], S_IWUGO, mux_dbg_dir,
> 					  m, &omap_mux_dbg_signal_fops);
> 	}
> }
> 
> is that really expected ? I guess not, attached there's a small patch to
> fix that one.

Heh, no it should not be like that, thanks will queue as a fix.

Tony