From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Deti Fliegl <deti@fliegl.de>
Subject: Re: [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD
Date: Sat, 5 Feb 2011 15:29:47 +0100 [thread overview]
Message-ID: <20110205152947.43375cb4@stein> (raw)
In-Reply-To: <201102051417.22874.hverkuil@xs4all.nl>
On Feb 05 Hans Verkuil wrote:
> (Second attempt: fixes a link issue with firedtv and adds removal of the old ioctls)
>
> This patch series removes the last V4L1 drivers (Yay!), the obsolete dabusb driver,
> the ieee1394-stack part of the firedtv driver (the IEEE1394 stack was removed in
> 2.6.37), and the VIDIOC_*_OLD ioctls.
>
> Stefan, I went ahead with this since after further research I discovered that
> this driver hasn't been compiled at all since 2.6.37! The Kconfig had a
> dependency on IEEE1394, so when that config was removed, the driver no longer
> appeared in the config.
>
> I removed any remaining reference to IEEE1394 and changed the Kconfig dependency
> to FIREWIRE. At least it compiles again :-)
Thanks for doing the firedtv cleanup. However, the effect should just be
that of dead code elimination. Was there any build problem that I missed?
AFAICS, firedtv builds and works fine in mainline 2.6.37(-rc) and
2.6.38(-rc). From when I implemented the drivers/firewire/ backend of
firedtv, it should have been possible to build firedtv for a kernel with
one or both of drivers/{ieee1394,firewire}; controlled by whether
CONFIG_{IEEE1394,FIREWIRE} are defined or not.
I will have a look at your changes later.
--
Stefan Richter
-=====-==-== --=- --=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-02-05 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 13:17 [GIT PATCHES FOR 2.6.39] Remove se401, usbvideo, dabusb, firedtv-1394 and VIDIOC_OLD Hans Verkuil
2011-02-05 14:29 ` Stefan Richter [this message]
2011-02-05 14:48 ` Hans Verkuil
2011-02-06 11:18 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110205152947.43375cb4@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=deti@fliegl.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.