Re: [PATCH] xentrace: dynamic tracebuffer size allocation

[Olaf Hering <olaf@aepfle.de>]

On Sat, Feb 05, Olaf Hering wrote:

> 
> Allocate tracebuffers dynamically, based on the requested buffer size.
> Calculate t_info_size from requested t_buf size.
> Fix allocation failure path, free pages without the spinlock.
> The spinlock is not needed since tracing is not yet enabled.
> Remove casts for rawbuf, it can be a void pointer since no math is done.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>

plus this change to fix a compile error after spinlock removal..


Index: xen-unstable.hg-4.1.22870/xen/common/trace.c
===================================================================
--- xen-unstable.hg-4.1.22870.orig/xen/common/trace.c
+++ xen-unstable.hg-4.1.22870/xen/common/trace.c
@@ -185,7 +185,6 @@ static int alloc_trace_bufs(unsigned int
      */
     for_each_online_cpu(cpu)
     {
-        int flags;
         void *rawbuf;
         struct t_buf *buf;
 
@@ -243,7 +242,6 @@ static int alloc_trace_bufs(unsigned int
 out_dealloc:
     for_each_online_cpu(cpu)
     {
-        int flags;
         void *rawbuf;
 
         rawbuf = per_cpu(t_bufs, cpu);